app-misc/mosquitto: bump to 1.6.2 #12037

oxr463 · 2019-05-18T02:19:23Z

Package-Manager: Portage-2.3.66, Repoman-2.3.12
Signed-off-by: Lucas Ramage [email protected]

gentoo-bot · 2019-05-18T02:20:11Z

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Submitter: @oxr463
Areas affected: ebuilds
Packages affected: app-misc/mosquitto

app-misc/mosquitto: @oxr463, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

mgorny

distcc[54] ERROR: compile (null) on localhost failed
persist_read_test.c:6:10: fatal error: CUnit/CUnit.h: No such file or directory
 #include <CUnit/CUnit.h>
          ^~~~~~~~~~~~~~~
compilation terminated.
distcc[52] ERROR: compile persist_read_test.c on localhost failed
make[2]: *** [<builtin>: persist_read_test.o] Error 1

oxr463 · 2019-05-23T01:12:51Z

distcc[54] ERROR: compile (null) on localhost failed
persist_read_test.c:6:10: fatal error: CUnit/CUnit.h: No such file or directory
 #include <CUnit/CUnit.h>
          ^~~~~~~~~~~~~~~
compilation terminated.
distcc[52] ERROR: compile persist_read_test.c on localhost failed
make[2]: *** [<builtin>: persist_read_test.o] Error 1

Ping @mgorny, please check again.

mgorny · 2019-05-23T07:31:40Z

 * QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:
 * /usr/bin/mosquitto_pub
 * /usr/bin/mosquitto_rr
 * /usr/bin/mosquitto_sub

mgorny · 2019-05-23T07:31:55Z

RepoMan scours the neighborhood...
  RDEPEND.suspect               1
   app-misc/mosquitto/mosquitto-1.6.2.ebuild: 'test?' USE conditional in RDEPEND

oxr463 · 2019-05-23T22:20:51Z

 * QA Notice: Files built without respecting LDFLAGS have been detected
 *  Please include the following list of files in your report:
 * /usr/bin/mosquitto_pub
 * /usr/bin/mosquitto_rr
 * /usr/bin/mosquitto_sub

How did you get this output?

I'm running this command to install:

FEATURES="test" ACCEPT_KEYWORDS="~amd64" USE="bridge" emerge app-misc/mosquitto

RepoMan scours the neighborhood...
  RDEPEND.suspect               1
   app-misc/mosquitto/mosquitto-1.6.2.ebuild: 'test?' USE conditional in RDEPEND

Oops, I'll move that into DEPEND directly.

mgorny · 2019-05-24T05:02:44Z

On Thu, 2019-05-23 at 15:20 -0700, rage wrote: > ``` > * QA Notice: Files built without respecting LDFLAGS have been detected > * Please include the following list of files in your report: > * /usr/bin/mosquitto_pub > * /usr/bin/mosquitto_rr > * /usr/bin/mosquitto_sub > ``` How did you get this output?

`LDFLAGS="-Wl,--defsym=__gentoo_check_ldflags__=0"`

oxr463 · 2019-05-27T00:14:08Z

Created an issue upstream, (See: eclipse/mosquitto#1294).

oxr463 · 2019-05-27T22:43:58Z

@mgorny please review again. Thank you

oxr463 · 2019-06-01T17:49:09Z

Ping @mgorny

app-misc/mosquitto/mosquitto-1.6.2.ebuild

oxr463 · 2019-06-07T01:02:20Z

@mgorny, I made the requested changes, however, the test-suite is failing for me due to a kernel upgrade, (I think?), eclipse/mosquitto#1307.

mgorny · 2019-06-08T07:36:25Z

I get:

./11-message-expiry.py
1559979290: mosquitto version 1.6.2 starting
1559979290: Config loaded from 11-message-expiry.conf.
1559979290: Opening ipv4 listen socket on port 1888.
1559979290: Opening ipv6 listen socket on port 1888.
1559979290: New connection from ::1 on port 1888.
1559979290: Socket error on client <unknown>, disconnecting.
1559979292: New connection from 127.0.0.1 on port 1888.
1559979292: New client connected from 127.0.0.1 as subpub-qos0-test (p5, c0, k60).
1559979292: No will message specified.
1559979292: Sending CONNACK to subpub-qos0-test (1, 0)
1559979292: Sending PUBLISH to subpub-qos0-test (d0, q1, r0, m1, 'subpub/qos1', ... (8 bytes))
1559979292: Sending PUBLISH to subpub-qos0-test (d0, q1, r0, m2, 'subpub/qos1', ... (8 bytes))
1559979292: Sending PUBLISH to subpub-qos0-test (d0, q1, r0, m3, 'subpub/qos1', ... (8 bytes))
1559979292: Socket error on client subpub-qos0-test, disconnecting.
1559979292: mosquitto version 1.6.2 terminating
1559979292: Saving in-memory database to mosquitto-1888.db.

Maybe run it a few times to see if it's flakiness.

oxr463 · 2019-06-13T01:07:06Z

I get:

./11-message-expiry.py
1559979290: mosquitto version 1.6.2 starting
1559979290: Config loaded from 11-message-expiry.conf.
1559979290: Opening ipv4 listen socket on port 1888.
1559979290: Opening ipv6 listen socket on port 1888.
1559979290: New connection from ::1 on port 1888.
1559979290: Socket error on client <unknown>, disconnecting.
1559979292: New connection from 127.0.0.1 on port 1888.
1559979292: New client connected from 127.0.0.1 as subpub-qos0-test (p5, c0, k60).
1559979292: No will message specified.
1559979292: Sending CONNACK to subpub-qos0-test (1, 0)
1559979292: Sending PUBLISH to subpub-qos0-test (d0, q1, r0, m1, 'subpub/qos1', ... (8 bytes))
1559979292: Sending PUBLISH to subpub-qos0-test (d0, q1, r0, m2, 'subpub/qos1', ... (8 bytes))
1559979292: Sending PUBLISH to subpub-qos0-test (d0, q1, r0, m3, 'subpub/qos1', ... (8 bytes))
1559979292: Socket error on client subpub-qos0-test, disconnecting.
1559979292: mosquitto version 1.6.2 terminating
1559979292: Saving in-memory database to mosquitto-1888.db.

Maybe run it a few times to see if it's flakiness.

I tried it again in a virtual machine running Linux kernel 4.19, and I'm getting the same error as before so I don't think it has anything to do with my kernel version.

Package-Manager: Portage-2.3.66, Repoman-2.3.12 Signed-off-by: Lucas Ramage <[email protected]>

oxr463 · 2019-06-22T02:10:30Z

@mgorny, please review. I removed all failing tests from the Makefile.

gentoo-repo-qa-bot · 2019-06-22T02:30:44Z

Pull request CI report

Report generated at: 2019-06-22 02:30 UTC
Newest commit scanned: f31fff8
Status: ✅ good

No issues found

mgorny · 2019-06-22T07:21:59Z

Do you have any clue why they fail? Is upstream aware?

oxr463 · 2019-06-22T10:35:09Z

Do you have any clue why they fail? Is upstream aware?

I'm not 100% sure why they are failing, but I created an issue upstream; I'll continue troubleshooting from there.

gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels May 18, 2019

mgorny requested changes May 21, 2019

View reviewed changes

This comment has been minimized.

Sign in to view

mgorny requested changes Jun 1, 2019

View reviewed changes

app-misc/mosquitto/mosquitto-1.6.2.ebuild Outdated Show resolved Hide resolved

app-misc/mosquitto/mosquitto-1.6.2.ebuild Outdated Show resolved Hide resolved

app-misc/mosquitto/mosquitto-1.6.2.ebuild Outdated Show resolved Hide resolved

app-misc/mosquitto: bump to 1.6.2

f31fff8

Package-Manager: Portage-2.3.66, Repoman-2.3.12 Signed-off-by: Lucas Ramage <[email protected]>

gentoo-bot closed this in 4d1390a Jun 22, 2019

oxr463 deleted the app-misc/mosquitto-1.6.2 branch June 22, 2019 10:35

oxr463 restored the app-misc/mosquitto-1.6.2 branch June 22, 2019 10:46

oxr463 deleted the app-misc/mosquitto-1.6.2 branch February 24, 2020 16:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

app-misc/mosquitto: bump to 1.6.2 #12037

app-misc/mosquitto: bump to 1.6.2 #12037

oxr463 commented May 18, 2019

gentoo-bot commented May 18, 2019

mgorny left a comment

oxr463 commented May 23, 2019

mgorny commented May 23, 2019

mgorny commented May 23, 2019

oxr463 commented May 23, 2019

mgorny commented May 24, 2019 via email

This comment has been minimized.

oxr463 commented May 27, 2019

oxr463 commented May 27, 2019

oxr463 commented Jun 1, 2019

oxr463 commented Jun 7, 2019

mgorny commented Jun 8, 2019

oxr463 commented Jun 13, 2019

oxr463 commented Jun 22, 2019

gentoo-repo-qa-bot commented Jun 22, 2019

mgorny commented Jun 22, 2019

oxr463 commented Jun 22, 2019

app-misc/mosquitto: bump to 1.6.2 #12037

app-misc/mosquitto: bump to 1.6.2 #12037

Conversation

oxr463 commented May 18, 2019

gentoo-bot commented May 18, 2019

Copyright policy change

Pull Request assignment

Linked bugs

mgorny left a comment

Choose a reason for hiding this comment

oxr463 commented May 23, 2019

mgorny commented May 23, 2019

mgorny commented May 23, 2019

oxr463 commented May 23, 2019

mgorny commented May 24, 2019 via email

This comment has been minimized.

oxr463 commented May 27, 2019

oxr463 commented May 27, 2019

oxr463 commented Jun 1, 2019

oxr463 commented Jun 7, 2019

mgorny commented Jun 8, 2019

oxr463 commented Jun 13, 2019

oxr463 commented Jun 22, 2019

gentoo-repo-qa-bot commented Jun 22, 2019

Pull request CI report

mgorny commented Jun 22, 2019

oxr463 commented Jun 22, 2019