Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added frr-gentoo overlay #88

Closed
wants to merge 3 commits into from
Closed

Added frr-gentoo overlay #88

wants to merge 3 commits into from

Conversation

f0o
Copy link
Contributor

@f0o f0o commented Nov 26, 2017

No description provided.

@ChrisADR
Copy link
Contributor

ChrisADR commented Nov 26, 2017

Hi @f0o, please review these points:

  • You need to copy/paste the GITHUB TEMPLATE (located in files/overlays/repositories.xml)
  • The list is Name sorted, which means that your XML input needs to be on the 'F' segment, not the end of the list.
  • Please rebase all your fixes in a single commit with the appropriate name (Added frr-gentoo overlay); if you don't know how it would be easier to create a new PR when all is fixed.

Thank you

Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @ChrisADR said.

@f0o
Copy link
Contributor Author

f0o commented Nov 26, 2017

@ChrisADR Will do tomorrow, there's also a chance that the source-location of the overlay may change if FRR decides to take over. So there's no rush from my side right now.

I'm closing and re-opening a new PR so your team wont have dangling, stale, PRs in the queue.

@f0o f0o closed this Nov 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants