Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAPI=4/5 ebuilds updated/removed from salfter overlay...please re-add #508

Closed
wants to merge 3 commits into from
Closed

EAPI=4/5 ebuilds updated/removed from salfter overlay...please re-add #508

wants to merge 3 commits into from

Conversation

salfter
Copy link
Contributor

@salfter salfter commented Apr 14, 2022

WRT https://bugs.gentoo.org/792843...was a bit late catching this, but if the problem was what I think it is, it's been fixed.

@laumann
Copy link
Contributor

laumann commented Apr 15, 2022

Sure, could you amend the commit message and add a reference to the bug? Like this:

Bug: https://bugs.gentoo.org/792843

@laumann
Copy link
Contributor

laumann commented Apr 15, 2022

I think even better is to do just:

git revert 31746197a97eb70829afb75db3dcd19d37448ae4

and expand the commit message to explain the fixes done, and add the bug ref.

EAPI=4/5 ebuilds updated/removed from salfter overlay...please revert removal

Revert "repositories.xml: remove 'salfter' overlay"

This reverts commit 3174619.
@laumann
Copy link
Contributor

laumann commented Apr 17, 2022

Sorry for not being clearer @salfter I meant for it to be just one commit, with a message like this:

Revert "repositories.xml: remove 'salfter' overlay"

This reverts commit 31746197a97eb70829afb75db3dcd19d37448ae4.

EAPI 4/5 ebuilds either updated or removed.

Bug: https://bugs.gentoo.org/792843

(you could also add a Signed-off-by: line after the Bug: line)

EDIT I would do git revert -e 31746197a97eb70829afb75db3dcd19d37448ae4 and add commentary to the commit message.

@salfter
Copy link
Contributor Author

salfter commented Apr 18, 2022

It might be better at this point to close this request and open a new one. I have a new branch waiting with just the one revert commit in it that will be uploaded shortly. It seems to be the only way to keep unwanted cruft out of the repo.

@salfter salfter closed this Apr 18, 2022
@salfter salfter deleted the readd-salfter branch April 18, 2022 14:35
@salfter
Copy link
Contributor Author

salfter commented Apr 18, 2022

New PR in #510 supersedes this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants