Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repositories: Add trojan overlay #147

Closed
wants to merge 3 commits into from
Closed

repositories: Add trojan overlay #147

wants to merge 3 commits into from

Conversation

YangMame
Copy link
Contributor

@YangMame YangMame commented Jul 8, 2018

No description provided.

@YangMame
Copy link
Contributor Author

YangMame commented Jul 8, 2018

this repo is not belong to me... and I've asked him to register an account

@mgorny
Copy link
Member

mgorny commented Jul 8, 2018

I'm confused now. Do you have permission to add the other overlay?

Also, please git rebase -i origin and squash this into two commits, with proper commit messages for each repo added.

@YangMame
Copy link
Contributor Author

YangMame commented Jul 9, 2018

@mgorny yep,I'm part of them

Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also squash commits.

<owner type="person">
<email>[email protected]</email>
</owner>
<source type="git">git:https://github.com/Gig-OS/gig.git</source>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use git:https://, only https:// [+ ssh]. Please follow the example of other repos.

<repo quality="experimental" status="unofficial">
<name>trojan-gentoo</name>
<description lang="en">Gentoo overlay for trojan.</description>
<homepage>https://github.com/trojan-gfw/trojan-gentoo.git/</homepage>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub sites go without .git.

@YangMame
Copy link
Contributor Author

YangMame commented Jul 9, 2018

Oh...sorry for that...

@gentoo-bot gentoo-bot closed this in a174e05 Jul 9, 2018
@mgorny
Copy link
Member

mgorny commented Jul 9, 2018

Fixed and merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants