Test enhancement #25
Test enhancement #25
Conversation
|
Issue #26 is related, the tests don't pass using PHP 7.4. |
But the Travis CI has been passed on this PR. |
| @@ -2,7 +2,7 @@ language: php | |||
| php: | |||
| - 7.2 | |||
| - 7.3 | |||
| - 7.4snapshot | |||
| - 7.4 | |||
| - nightly | |||
| matrix: | |||
| include: | |||
There was a problem hiding this comment.
In order to build as in other PHP versions, I think php 7.4 with lowest and highest dependencies should be added
There was a problem hiding this comment.
Could you provide your suggested code snippets to resolve this issue you mention?
There was a problem hiding this comment.
Append to build matrix
- php: 7.4
env: dependencies=lowest
- php: 7.4
env: dependencies=highest
8c7ec5b
to
c9a2d00
Compare
| </xsl:stylesheet> |
There was a problem hiding this comment.
Modify files for issue #26.
| @@ -1,6 +1,6 @@ | |||
| <xsl:stylesheet version="2.0" xmlns:xsl="https://www.w3.org/1999/XSL/Transform"> | |||
|
|
|||
| <xsl:template> | |||
| <xsl:template name="foo"> | |||
There was a problem hiding this comment.
Modify files for issue #26.
| @@ -1,6 +1,6 @@ | |||
| <xsl:stylesheet version="3.0" xmlns:xsl="https://www.w3.org/1999/XSL/Transform"> | |||
|
|
|||
| <xsl:template> | |||
| <xsl:template name="foo"> | |||
There was a problem hiding this comment.
Modify files for issue #26.
|
Just found that your PR is based on |
c9a2d00
to
d8d484b
Compare
Hi @eclipxe13, thanks for your reply. I've rebased a2a1500 and let php-7.4 have lowest/highest dependencies environment variable during Travis CI build. |
|
sweet! now lets wait for maintainer to check our pull requests |
|
Fantastic work! |
Changed log
php-7.4version is available on Travis CI build.php-7.4version fromallow_failuressetting o Travis CI build.setUpandtearDownmethods areprotected.