Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding _noiea to the dataset value in goa rna datasets #1184

Merged
merged 2 commits into from
Sep 27, 2019
Merged

Conversation

dougli1sqrd
Copy link
Contributor

No description provided.

@kltm
Copy link
Member

kltm commented Sep 26, 2019

As discussed in #1168 , we will be backing out of this.

@kltm kltm closed this Sep 26, 2019
@kltm
Copy link
Member

kltm commented Sep 26, 2019

Will reuse.

@kltm kltm reopened this Sep 26, 2019
@dougli1sqrd
Copy link
Contributor Author

dougli1sqrd commented Sep 26, 2019

Okay new commit. @kltm is this putting back the original IDs. Can you double check the url field to make sure that is correct? @kltm

@kltm
Copy link
Member

kltm commented Sep 26, 2019

This looks fine to my eye.
As far as the url field goes...it's technically not up to date. See:

url: https://current.geneontology.org/annotations/dictybase.gaf.gz

That said, I can't recall off the top of my head why we haven't updated these. Perhaps an oversight? Any thoughts @pgaudet ?
If this is what was historically in there, let's just go with that.

@kltm
Copy link
Member

kltm commented Sep 27, 2019

@pgaudet Okay, this is weird; I'm going to reopen #804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants