Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gorule-0000030 test is not failing #2093

Closed
pgaudet opened this issue Oct 6, 2023 · 5 comments
Closed

gorule-0000030 test is not failing #2093

pgaudet opened this issue Oct 6, 2023 · 5 comments
Assignees
@mugitty
Labels
annotation rule
Projects
GORULES (low-hanging fruit)

Comments

@pgaudet
Copy link
Contributor

pgaudet commented Oct 6, 2023 •
edited
Loading

It seems gorule-0000030 is not implemented correctly; the test in the test GAF is not failing
Added a test (TEST 2) with GO_REF:0000033; it may be that this is the only GOREF tested (see #1118)

  • Need to know if the obsoleted status (which is a boolean value in the go_ref file) of the reference is checked in the goref file or if it is hard coded in the rule
@pgaudet pgaudet mentioned this issue Oct 6, 2023
Open
@pgaudet pgaudet moved this from TODO to In progress in GORULES (low-hanging fruit) Oct 12, 2023
@pgaudet
Copy link
Contributor Author

pgaudet commented Oct 13, 2023

Once tests fail correctly, consider implementing this rule as an error, see #1423

mugitty added a commit that referenced this issue Oct 19, 2023
@mugitty
For #2093
fa64781
@kltm kltm mentioned this issue Oct 24, 2023
Merged
@pgaudet
Copy link
Contributor Author

pgaudet commented Oct 25, 2023

Ontobio code fixed, see biolink/ontobio#653 (review)

mugitty added a commit that referenced this issue Oct 26, 2023
@mugitty
For #2081,#2093
76c5872
mugitty added a commit that referenced this issue Oct 31, 2023
@mugitty
For #2093,#2081 Updating for ontobio release
d41fccc
@pgaudet
Copy link
Contributor Author

pgaudet commented Nov 6, 2023

tests not failing

@pgaudet
Copy link
Contributor Author

pgaudet commented Nov 7, 2023

Looks like this is working, but that we're not using the latest versions of the GOREFs, since GOREF_0000033 is returning an error, but it has been un-obsoleted

@pgaudet pgaudet moved this from In progress to Clearing in GORULES (low-hanging fruit) Nov 7, 2023
mugitty added a commit that referenced this issue Nov 14, 2023
@mugitty
For #2093 Update to latest ontobio release
b37c3c1
mugitty added a commit that referenced this issue Nov 14, 2023
@mugitty
Merge pull request #2127 from geneontology/issue-2093-metadata
4308751 
For #2093
@pgaudet
Copy link
Contributor Author

pgaudet commented Nov 21, 2023

Now looks OK in the test GAF.

mugitty added a commit that referenced this issue Nov 23, 2023
@mugitty
For #2093 update for latest version of ontobio
9ba3c5d
@pgaudet pgaudet closed this as completed Nov 30, 2023
@pgaudet pgaudet moved this from Clearing to Done in GORULES (low-hanging fruit) Nov 30, 2023
mugitty added a commit that referenced this issue Dec 1, 2023
@mugitty
For #2093 updated to latest ontobio release
cfd0877
@kltm kltm mentioned this issue Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mugitty mugitty

Labels
annotation rule
Projects
GORULES (low-hanging fruit)
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pgaudet @mugitty