-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add entity type 'protein' for IKR evidence #1882
Comments
Thanks @pgaudet . Sounds like this would fix things for my use case. I think the alternative is to change the "type_name" of the MEROPS entry in the GO xrefs metadata to "gene/protein family" - see #1875. I'm not sure which solution is better/easier?? FYI: Looking at all MF annotations in QuickGO, I don't see any annotations using 'MEROPS' in the with/from column, so any change here won't affect any existing annotations - it will just determine how we can use MEROPS IDs in IKR annotations going forward. |
Right! since it wasn't allowed until now. Thanks for checking! |
Right, but given there's a MEROPS entry in the GO xrefs metadata file (#1875) and I don't know how long that's been there, I wanted to check if there's been any usage of MEROPS IDs in any context (e.g. ISS?) to date. Seems not. |
Hi @sjm41 which is something like C01.### (where ### is a number) Do you need the identifiers with 3 letters after the dot? We cannot find an 'official source' for that format, but we can relax the rules if needed. Thanks, Pascale |
Hi @pgaudet |
Looking at the MEROPS IDs I want to use (at least), the ### bit corresponds to one of 3 regular expressions:
|
This is working using the syntax provided by identifiers.org I guess this may be a separate/downstream issue, maybe specific to P2GO?? |
Thanks @pgaudet and @alexsign for continuing to work on this! Good news is that I now see 'MEROPS' (and 'MEROPS_fam') in the drop-down menu on protein2GO: Other good news is that a ID like "S09.986" (ie. three numbers after the dot) or "S01.A18" (one letter + two numbers after the dot) is a valid entry (entered with 'MEROPS' selected in the drop-down). Bad news is that IDs like "C85.UNA" (ie. three letters after the dot) isn't allowed. Can you check the regex again? Many thanks!! |
Can we also clarify the difference between 'MEROPS' and 'MEROPS_fam' in the menu? |
Should now work |
Yep, confirming that IDs like "C85.UNA" (ie. three letters after the dot) now work. Thanks! |
Notes from quick chat with Pascale:
|
Remove protein family for IKR https://github.com/geneontology/go-site/compare/master...pgaudet-patch-71?quick_pull=1 Hopefully this should do it. |
We want to do this to allow using MEROPs (and perhaps other resources) as evidence for IKR annotations.
Specific example from @sjm41
PR is here:#1881
Thanks, Pascale
The text was updated successfully, but these errors were encountered: