Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of Gene in the model #31

Closed
cmungall opened this issue Jul 11, 2019 · 4 comments
Closed

Use of Gene in the model #31

cmungall opened this issue Jul 11, 2019 · 4 comments

Comments

@cmungall
Copy link
Member

cmungall commented Jul 11, 2019

It's not clear that we should use Gene in the model (except in cases of target of transcription etc).

Although we use gene IDs in the models, the IRIs are uncommitted as to what kind of entity they represent, and in neo we just assert them to be information macromolecules. In fact a gene is not actually the object of enabled_by, it's really the product of that gene

See also gene LocatedIn cell component - the gene is always located on the chromosome...

@pgaudet
Copy link
Contributor

pgaudet commented Jul 12, 2019

We need to also thing about the complication of using different ID spaces for genes and proteins - the simplest solution would be to use the same ID space and for specific terms specify whether we mean gene or gene product (or something along those lines)

@ukemi
Copy link

ukemi commented Jul 12, 2019

Doesn't NEO take care of this?

@pgaudet
Copy link
Contributor

pgaudet commented Jul 12, 2019

Does it ?

@vanaukenk
Copy link
Contributor

See #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants