Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relations to add to Molecular Function #17

Closed
vanaukenk opened this issue Jul 11, 2019 · 9 comments
Closed

Relations to add to Molecular Function #17

vanaukenk opened this issue Jul 11, 2019 · 9 comments
Assignees

Comments

@vanaukenk
Copy link
Contributor

vanaukenk commented Jul 11, 2019

From discussions on 2019-07-10, there are additional relations to add to MF:

PREFIX GoBiologicalPhase: http:https://purl.obolibrary.org/obo/GO_0044848
happens_during: @<BiologicalPhase> *;

regulates: @<MolecularFunction> {0,1};

negatively_regulates: @<MolecularFunction> {0,1};

positively_regulates: @<MolecularFunction> {0,1};

directly_regulates: @<MolecularFunction> {0,1};

directly_negatively_regulates: @<MolecularFunction> {0,1};

directly_positively_regulates: @<MolecularFunction> {0,1};

causally_upstream_of_or_within: @<BiologicalProcess> {0,1};

causally_upstream_of_or_within, negative effect: @<BiologicalProcess> {0,1};

causally_upstream_of_or_within, positive effect: @<BiologicalProcess> {0,1};

causally_upstream_of: @<BiologicalProcess> {0,1};

causally_upstream_of, negative effect: @<BiologicalProcess> {0,1};

causally_upstream_of, positive effect: @<BiologicalProcess> {0,1};

@ukemi
Copy link

ukemi commented Jul 11, 2019

Do we want to keep directly_regulates versus regulates distinctions? If so, we need to specify exactly what they mean.

@vanaukenk
Copy link
Contributor Author

Yes, @pgaudet and I were discussing that. For now, we included it, but I agree that we need to be clear on when each would be used.

@cmungall
Copy link
Member

Note that we could make this more stringent. Do we want to say in fact that the MA should have at most one outgoing causal edge of any type? This could be done with a union expression in shex, e.g. (r1 | r2 | .... | rn)

@pgaudet
Copy link
Contributor

pgaudet commented Jul 12, 2019

Do we want to say in fact that the MA should have at most one outgoing causal edge of any type?

We need to look at examples. This is not how I read our diagram from the google doc, but we had not yet gotten to reviewing that part.

Pascale

@vanaukenk
Copy link
Contributor Author

One relevant example to look at here would be transcription factor activity and how that activity will be related to multiple, downstream targets.

This remains an outstanding modeling question: do we create one node for the transcription factor activity and link that one node to multiple targets or do we create a separate transcription factor activity node for each individual target?

@ukemi
Copy link

ukemi commented Jul 12, 2019

And if possible, we should try to tease apart the tool behavior from the underlying model. It's pretty clear that if we decide we want to create the separate activities, curators aren't going to want to have to do this manually and will need a way to do it as a 'short cut'.

@pgaudet
Copy link
Contributor

pgaudet commented Jul 12, 2019

This remains an outstanding modeling question: do we create one node for the transcription factor activity and link that one node to multiple targets or do we create a separate transcription factor activity node for each individual target?

This touches the instance vs class discussion - should we open a ticket for that and discuss pros and cons thoroughly at some point ?

@vanaukenk
Copy link
Contributor Author

There may already be a ticket. I can look.

@balhoff
Copy link
Member

balhoff commented Jul 24, 2019

These have all been added. They are cardinality * rather than {0,1}, though so please reopen if that needs to be changed.

@balhoff balhoff closed this as completed Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants