-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EC:1.14.12 is being used as an xref in multiple enzyme activities #12948
Comments
I'll check these to see if EC2GO maps these to multiple terms; use more unique if available. |
So looking at the ec2go file; as expected, this is mapping to all children of EC:1.14.12 EC:1.14.12 > GO:oxidoreductase activity, acting on paired donors, with incorporation or reduction of molecular oxygen, NAD(P)H as one donor, and incorporation of two atoms of oxygen into one donor ; GO:0016708 |
We might need a rule that EC number used for xrefs MUST have 4 numbers, not three. Otherwise, the mapping to a GO term is NOT unique |
see EC:6.5.1 (DNA and RNA ligase) |
Also, demonstrating what Chris mentioned, we have three GO terms that have Xrefs to EC:6.5.1, two of which have a parent term that has an even more general Xref to EC, but we don't have a GO term that could uniquely map to EC:6.5.1. We also have a more specific term that is a child of one of the other terms that has the same Xref.
|
This is ongoingly being fixed as many came in from plant enzyme project. Thought I got them all but some still pop up now and then and are usually covered by their individual tickets. |
These are still being looked at from long list to remove 3 digit EC from leaf terms. Focusing on these two for this ticket. |
pinging @hdrabkin |
As of today, I don't see any terms with a EC:6.5.1.- xref, so that seems fixed. But there are still 19 terms with inappropriate EC:1.14.12.- xref: id: GO:0018603 id: GO:0018604 id: GO:0018606 id: GO:0018607 id: GO:0018608 id: GO:0018609 id: GO:0018611 id: GO:0018612 id: GO:0018613 id: GO:0018614 id: GO:0018615 id: GO:0018617 id: GO:0034521 id: GO:0034825 id: GO:0034906 id: GO:0034907 id: GO:0034908 id: GO:0034911 id: GO:0034954 |
These appear to be coming in via UM-BBD_reactionIDs.
The term EC:1.14.12 appears to be a very generic term, much like a EC:1.14.12.-
There are around 30 terms with EC:1.14.12 as an xref.
There are EC:1.14.12.19, EC:1.14.12.17; these are unique. No problem.
Concern: aren't xrefs suppose to be unique?
The text was updated successfully, but these errors were encountered: