Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guide): update nextjs guide for @types/react #784

Merged
merged 1 commit into from
Jul 5, 2022
Merged

docs(guide): update nextjs guide for @types/react #784

merged 1 commit into from
Jul 5, 2022

Conversation

harshcut
Copy link
Contributor

Description

Currently, the guide for Next.js in Server Render gives a type error after updating @types/react to ^18.0.0. The overwrite of styles seems to be causing trouble. The styles are of type styles?: ReactFragment | ReactElement<any, string | JSXElementConstructor<any>>[] | undefined instead of JSX.Element.

Screenshots

image

image

@netlify
Copy link

netlify bot commented Jun 10, 2022

Deploy Preview for geist-ui ready!

Name Link
🔨 Latest commit 4e00d8d
🔍 Latest deploy log https://app.netlify.com/sites/geist-ui/deploys/62a318ddef0bd20009d5dcb8
😎 Deploy Preview https://deploy-preview-784--geist-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #784 (4e00d8d) into master (6e70232) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #784   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files         198      198           
  Lines        3046     3046           
  Branches      668      668           
=======================================
  Hits         3011     3011           
  Misses         34       34           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e70232...4e00d8d. Read the comment docs.

@unix unix added the type: documentation Improvements or additions to documentation label Jul 5, 2022
@unix unix merged commit 3b942df into geist-org:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants