Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Tags #182

Merged
merged 12 commits into from
Sep 5, 2020
Merged

Feature: Tags #182

merged 12 commits into from
Sep 5, 2020

Conversation

zakariaelas
Copy link
Contributor

See #174 for more information about the initial discussion.

@yjose one thing to note: Initially, we had a ton of tags. This is because of a couple of reasons:

  1. Because of how the group works in GraphQL queries in Gatsby, it is case sensitive. This means that Dev and dev result in two different tags.
  2. The tags have not been consistent across episodes. Tags were written in different ways when they mean the same thing. (ex: mobile and mobile dev, react native and ReactNative, etc.)
  3. Sometimes, tags were a bit too specific. Ex: women in tech. I think we can just use something short and clear like women, and it would represent the same thing.

I went through all the episodes and tried my best to fit most episodes under a general set of tags. I believe it became somewhat acceptable, but feel free to narrow it down further.

If you approve the feature in general, I suggest we try to follow a standard in future episodes. I can add a section in the docs about this. For example:

Use all uppercase letters for acronyms like AI, ML, MSS, etc.
Use all lowercase letters for abbreviations and words like dev, frontend, react native, etc.

@netlify
Copy link

netlify bot commented Aug 30, 2020

Deploy preview for geeksblabla ready!

Built with commit 593f3ee

https://deploy-preview-182--geeksblabla.netlify.app

@yjose
Copy link
Member

yjose commented Aug 30, 2020

@ismailElazizi would love to hear your thoughts about tags, we have a lot of tags, do you think this is the best way to do it https://deploy-preview-182--geeksblabla.netlify.app/blablas

@soufyanelf
Copy link
Contributor

soufyanelf commented Aug 31, 2020

Can we hide the tags and let the user display them when its needed

@yjose
Copy link
Member

yjose commented Aug 31, 2020

Good approach @soufianelf, i would suggest to show first tags line and ••• To show and hide others. What you think @zakariaelas

@zakariaelas
Copy link
Contributor Author

zakariaelas commented Aug 31, 2020

Good idea @soufianelf @yjose , a toggle would be a good solution. Small concern from a technical side, we will need to find a way to persist the toggle state between the different pages (/blablas, /${tag}/, etc.). I don't have a lot of experience with gatsby, but I believe we will need to use a gatsby browser API (wrapPageElement). Is that okay ?

@yjose
Copy link
Member

yjose commented Aug 31, 2020

yeah you can try to add it a theme state, theme component is already in the root https://github.com/DevC-Casa/geeksblabla.com/blob/master/gatsby-browser.js

@zakariaelas
Copy link
Contributor Author

Great, I'll work on it as soon as I have some time this week.

@yjose
Copy link
Member

yjose commented Sep 1, 2020

Guys, just come in my mind to use categories instead of tags as for some tags we only have 1 or 2 episode and the page look wired.

I would suggest to use categories instead, in such case we will have 4 categories : career, dev, mss, AMA

@soufianelf @zakariaelas what you think?

@zakariaelas
Copy link
Contributor Author

@yjose i think it's better than using tags, because there are so many with only 1 or 2 episodes like you said.

Some questions so I can understand your idea better:

  1. Should we add a category field in the episode frontmatter? Personally I think it's better to do it this way so it becomes easy to add a category in the future.
  2. Should we create a page for each category i.e: /career/? I think we should so that people can share relevant categories with others or even bookmark them.
  3. What will happen to the tags field in the frontmatter of episodes? Should we leave them?

What do you guys think?

@yjose
Copy link
Member

yjose commented Sep 1, 2020

  1. Yes
  2. Yes
  3. I think we should leave them, as we are using them to generate cover add keywords SEO

@zakariaelas
Copy link
Contributor Author

@yjose finally got some time to work on your suggestion, please take a look and let me know what you think 🙏

@@ -3,7 +3,8 @@ date: 2018-10-25
time: 20h
duration: "1:22:38"
title: "Métier de développeur"
tags: ["dev"]
tags: ["dev", "career"]
category: "MSS"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be career

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yjose my bad 😆 . Fixed now 👍

@yjose
Copy link
Member

yjose commented Sep 5, 2020

LGTM, Thank you @zakariaelas for the great work

@soufyanelf
Copy link
Contributor

Sounds good we can think more about the categories later we can add more categories like software security and entrepreneurship

@zakariaelas
Copy link
Contributor Author

@soufianelf sounds good. I have also updated the docs to let contributors know about the category field. Also, I have provided a standard way for everyone to add tags to episodes, just in case you would want to use tags one way or another in the future. It's better to stay consistent across all episodes.

@soufyanelf
Copy link
Contributor

awesome thanks @zakariaelas

@yjose yjose self-requested a review September 5, 2020 19:15
Copy link
Member

@yjose yjose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yjose yjose merged commit fc10fe2 into geeksblabla:master Sep 5, 2020
@yjose
Copy link
Member

yjose commented Sep 5, 2020

@zakariaelas you twitter handler or Facebook profile, please

@zakariaelas
Copy link
Contributor Author

@yjose
@21kelas on twitter, Zakaria El Asri on facebook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants