-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Tags #182
Feature: Tags #182
Conversation
Deploy preview for geeksblabla ready! Built with commit 593f3ee |
@ismailElazizi would love to hear your thoughts about tags, we have a lot of tags, do you think this is the best way to do it https://deploy-preview-182--geeksblabla.netlify.app/blablas |
Can we hide the tags and let the user display them when its needed |
Good approach @soufianelf, i would suggest to show first tags line and ••• To show and hide others. What you think @zakariaelas |
Good idea @soufianelf @yjose , a toggle would be a good solution. Small concern from a technical side, we will need to find a way to persist the toggle state between the different pages ( |
yeah you can try to add it a theme state, theme component is already in the root https://github.com/DevC-Casa/geeksblabla.com/blob/master/gatsby-browser.js |
Great, I'll work on it as soon as I have some time this week. |
Guys, just come in my mind to use categories instead of tags as for some tags we only have 1 or 2 episode and the page look wired. I would suggest to use categories instead, in such case we will have 4 categories : career, dev, mss, AMA @soufianelf @zakariaelas what you think? |
@yjose i think it's better than using tags, because there are so many with only 1 or 2 episodes like you said. Some questions so I can understand your idea better:
What do you guys think? |
|
@yjose finally got some time to work on your suggestion, please take a look and let me know what you think 🙏 |
blablas/ep7/index.md
Outdated
@@ -3,7 +3,8 @@ date: 2018-10-25 | |||
time: 20h | |||
duration: "1:22:38" | |||
title: "Métier de développeur" | |||
tags: ["dev"] | |||
tags: ["dev", "career"] | |||
category: "MSS" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be career
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yjose my bad 😆 . Fixed now 👍
LGTM, Thank you @zakariaelas for the great work |
Sounds good we can think more about the categories later we can add more categories like software security and entrepreneurship |
@soufianelf sounds good. I have also updated the docs to let contributors know about the category field. Also, I have provided a standard way for everyone to add tags to episodes, just in case you would want to use tags one way or another in the future. It's better to stay consistent across all episodes. |
awesome thanks @zakariaelas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@zakariaelas you twitter handler or Facebook profile, please |
@yjose |
See #174 for more information about the initial discussion.
@yjose one thing to note: Initially, we had a ton of tags. This is because of a couple of reasons:
group
works in GraphQL queries in Gatsby, it is case sensitive. This means thatDev
anddev
result in two different tags.women in tech
. I think we can just use something short and clear likewomen
, and it would represent the same thing.I went through all the episodes and tried my best to fit most episodes under a general set of tags. I believe it became somewhat acceptable, but feel free to narrow it down further.
If you approve the feature in general, I suggest we try to follow a standard in future episodes. I can add a section in the docs about this. For example: