wip: ipmi-pcap-decrypt command #47
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
instead of printing to stdout, another approach would be to decrypt the payload and write a new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #44 for background on this command.
To run:
This worked fine for our usecase, but it is quite limited since it only prints the raw deciphered payload bytes (without decoding them into proper packets).
I don't know how to achieve this with
gopacket.cmd/ipmi-pcap-decrypt/authenticator.gois copy/pasteauthenticator.go(can surely be optimized, by exporting the right methods/structs).Since the bug has been identified in our case, we (currently) don't need this tool anymore.
However I would be happy to provide feedback if needed!