Feature -> iOS: Spam notifications on ring when app was killed #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 7, 2024 10:29
gdelataillade
requested changes
May 7, 2024
| @@ -10,6 +10,7 @@ | |||
| 1498D2341E8E89220040F4C2 /* GeneratedPluginRegistrant.m in Sources */ = {isa = PBXBuildFile; fileRef = 1498D2331E8E89220040F4C2 /* GeneratedPluginRegistrant.m */; }; | |||
| 39EF213274CDCE732F2B8C44 /* Pods_Runner.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 98E1EA7FBDDCA7752F4C0FE7 /* Pods_Runner.framework */; }; | |||
| 3B3967161E833CAA004F5970 /* AppFrameworkInfo.plist in Resources */ = {isa = PBXBuildFile; fileRef = 3B3967151E833CAA004F5970 /* AppFrameworkInfo.plist */; }; | |||
| 7484BE252BE9100400D9AC5F /* marimba.mp3 in Resources */ = {isa = PBXBuildFile; fileRef = 7484BE242BE9100400D9AC5F /* marimba.mp3 */; }; | |||
There was a problem hiding this comment.
Il faudrait pas qu'il y ait d'audio importé dans le projet car il faudrait que ça puisse être n'importe quel audio et non un audio prédéfini.
There was a problem hiding this comment.
Il faudrait pas que ce fichier soit modifié.
| /// - nbrOfRepeat: 10 by default, this number must not be zero or negative. | ||
| /// - hour: Enter the scheduled wake-up time here, or the time at which the notification should go off. | ||
| /// - minute: Enter the scheduled wake-up time here, or the time at which the notification should go off. | ||
| func programLocalNotif(nbrOfRepeat: Int = 10, duration: Int = 10,hour: Int, minute: Int, title: String, body: String, sound: UNNotificationSound?) { |
There was a problem hiding this comment.
Pas besoin d'avoir la doc sur les paramètres ici.
| /// - add: This setting allows you to have intervals of 10 seconds between each notification: add * 10 | ||
| /// - hour: Notification trigger time (hour) | ||
| /// - minute: Notification trigger time (minute) | ||
| /// - Returns: The full and effective date of triggering the notification |
There was a problem hiding this comment.
Pas besoin d'avoir la doc sur les paramètres ici non plus.
lib/model/alarm_settings.dart
Outdated
| spamNotifOnKillIos: json['spamNotifOnKillIos'] as bool? ?? true, | ||
| nbrOfRepeat: json['nbrOfRepeat'] as int? ?? 10, | ||
| duration: json['duration'] as int? ?? 10, | ||
| notificationSound: json['notificationSound'] as String? ?? ''); |
There was a problem hiding this comment.
Il manque le trailing comma.
gdelataillade
changed the title
gdelataillade
requested changes
May 7, 2024
gdelataillade
requested changes
May 7, 2024
| iOSSpamNotificationSettings == other.iOSSpamNotificationSettings; | ||
| } | ||
|
|
||
| class IOSSpamNotificationSettings { |
There was a problem hiding this comment.
Faudrait mettre cette class dans un ficher à part dans src/model/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEATURE :
When the app is killed on IOS we can add a spam of X notification with a certain delay, you can custom the sound of the notification by adding a sound of less than 30sec on your IOS project (see in the exemple with marimba.mp3)