Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type stability of Jacobians and Hessian, fix test scenarios #337

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

gdalle
Copy link
Owner

@gdalle gdalle commented Jun 26, 2024

CI

  • Temporarily disable tests on 1.11 because JET picks up new type instabilities

DI source

  • Pre-allocate products for Jacobians and Hessians during preparation, to avoid creating closures in ntuple afterwards

DIT source

  • Adjust num_to_arr scenario to prevent JET errors on 1.11
  • Change reference gradient and hessian for arr_to_num scenarios so that it respects the array type of x (typically GPU arrays)

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.77%. Comparing base (83de009) to head (d3ea722).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
+ Coverage   96.75%   96.77%   +0.01%     
==========================================
  Files         101      101              
  Lines        4811     4831      +20     
==========================================
+ Hits         4655     4675      +20     
  Misses        156      156              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle changed the title Ensure type stability of test scenarios in 1.11 Improve type stability of Jacobians and Hessian, fix test scenarios Jun 26, 2024
@gdalle gdalle merged commit ff529cb into main Jun 26, 2024
36 checks passed
@gdalle gdalle deleted the gd/typestab11 branch June 26, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants