Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @gcollazo et al,
I was upgrading to Mongo 5 and by the time I got that working, version 6 was available. So, here goes:
I made some changes to allow an upgrade to Mongo
56.Overview:
convert to swift 5: I made a small update to Swift 5 syntax
upgrade to mongo 5: Finally I updated the Info.plist and update.sh files.
delete sparkle framework, add sparkle as swift package: I updated Sparkle to version 2 (without changing from the deprecated SUUpdater class)
build working; mongo 6: I fixed the build to work with Sparkle as a Swift package and ran the update.sh script. Lo and behold, we're on Mongo 6
Details:
The download page format has changed and can no longer be parsed for option tags, I parse the versions are stored in JSON, although there are other solutions (I could try parsing the html and there's a current.json endpoint mongo provides; however, between parsing HTML, JSON within HTML or a JSON endpoint and without being able to guarantee that a user has jq installed, it feels like there's no great solution.)
I updated the build target to from 10.9 to 10.11 to support the new version of Sparkle.