Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search implementation #25

Merged
merged 4 commits into from
Nov 25, 2022
Merged

Add search implementation #25

merged 4 commits into from
Nov 25, 2022

Conversation

gchristov
Copy link
Owner

@gchristov gchristov commented Nov 24, 2022 •
edited
Loading

What does this pull request change?

This PR implements search by:

  • providing new dedicated kmp-search and kmp-search-data modules where all logic lives
  • extracting HTML parsing into its own kmp-htmlparse and kmp-htmlparse-data modules
  • exposing a new SearchUseCase which is able to fetch randomised results from thecodinglove.com
  • adding test suites

How is this change tested?

Manually, with existing and new unit tests.

Writing Kotlin Multiplatform tests

@gchristov gchristov marked this pull request as ready for review November 25, 2022 15:13
@gchristov gchristov merged commit fe13f5f into master Nov 25, 2022
@gchristov gchristov deleted the feature/search branch November 25, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gchristov