Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Slack microfrontend asset paths are local #149

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

gchristov
Copy link
Owner

@gchristov gchristov commented Feb 29, 2024

What does this pull request change?

This PR decouples the Slack microfrontend's assets from the landing-page.

How is this change tested?

Manually.


Writing Kotlin Multiplatform tests

Copy link

pulumi bot commented Feb 29, 2024

🍹 The Update (preview) for gchristov/landing-page-web-service/prod was successful.

Resource Changes

    Name                             Type                            Operation
~   landing-page-web-service         gcp:cloudrunv2/service:Service  update
~   landing-page-web-service-binary  docker:index/image:Image        update

Copy link

pulumi bot commented Feb 29, 2024

🍹 The Update (preview) for gchristov/slack-web-service/prod was successful.

Resource Changes

    Name                      Type                            Operation
~   slack-web-service-binary  docker:index/image:Image        update
~   slack-web-service         gcp:cloudrunv2/service:Service  update

@gchristov gchristov marked this pull request as ready for review February 29, 2024 15:00
@gchristov gchristov merged commit 742885a into master Feb 29, 2024
8 checks passed
@gchristov gchristov deleted the slack-microfrontend-assets branch February 29, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant