Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack microfrontend #148

Merged
merged 10 commits into from
Feb 29, 2024
Merged

Slack microfrontend #148

merged 10 commits into from
Feb 29, 2024

Conversation

gchristov
Copy link
Owner

@gchristov gchristov commented Feb 29, 2024

What does this pull request change?

This PR:

  • splits up the /slack frontend into its own microfrontend using ExpressJS, adjusting the /slack/auth redirection to use the correct Slack client ID for the relevant environment (local/dev vs prod)
  • deletes the /slack resources in landing-page-web-service
  • moves the SlackConfig setup for slack-service to be in the domain module rather than adapter

How is this change tested?

Manually and with CI.


Writing Kotlin Multiplatform tests

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

pulumi bot commented Feb 29, 2024

🍹 The Update (preview) for gchristov/landing-page-web-service/prod was successful.

Resource Changes

    Name                             Type                            Operation
~   landing-page-web-service         gcp:cloudrunv2/service:Service  update
~   landing-page-web-service-binary  docker:index/image:Image        update

Copy link

pulumi bot commented Feb 29, 2024

🍹 The Update (preview) for gchristov/proxy-web-service/prod was successful.

Resource Changes

    Name                      Type                            Operation
~   proxy-web-service         gcp:cloudrunv2/service:Service  update
~   proxy-web-service-binary  docker:index/image:Image        update

Copy link

pulumi bot commented Feb 29, 2024

🍹 The Update (preview) for gchristov/slack-web-service/prod was successful.

Resource Changes

    Name                      Type                            Operation
~   slack-web-service-binary  docker:index/image:Image        update
~   slack-web-service         gcp:cloudrunv2/service:Service  update

Copy link

pulumi bot commented Feb 29, 2024

🍹 The Update (preview) for gchristov/slack-service/prod was successful.

Resource Changes

    Name                  Type                            Operation
~   slack-service-binary  docker:index/image:Image        update
~   slack-service         gcp:cloudrunv2/service:Service  update

@gchristov gchristov marked this pull request as ready for review February 29, 2024 11:27
@gchristov gchristov merged commit 83fbb71 into master Feb 29, 2024
20 checks passed
@gchristov gchristov deleted the slack-micro-frontend branch February 29, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant