Update Kenya static site branch with configurations #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add configuration variables to jekyll static site
DavidLemayian
suggested changes
Jul 11, 2017
s3_website.yml
Outdated
| @@ -1,6 +1,6 @@ | |||
| s3_id: <%= ENV['AWS_ACCESS_KEY_ID'] %> | |||
| s3_secret: <%= ENV['AWS_SECRET_ACCESS_KEY'] %> | |||
| s3_bucket: opengazettes.or.ke | |||
| s3_bucket: nigeria.opengazettes.co | |||
There was a problem hiding this comment.
@DavidLemayian Thanks. That's the config file I've been failing to change. I've moved the setting to use the environment variable set from the .env file
| @@ -8,7 +8,12 @@ | |||
| # Site settings | |||
| title: Open Gazettes Kenya | |||
| email: [email protected] | |||
| url: http:https://opengazettes.or.ke | |||
| url: http:https://opengazettes.or.ng | |||
|
Hey @andela-wcyn. ☝️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds the generic configuration settings to the
kenyabranch to reduce hard coding of valuesChanges Made
develop