Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few changes and fixes. #43

Merged
merged 3 commits into from Apr 17, 2017
Merged

Few changes and fixes. #43

merged 3 commits into from Apr 17, 2017

Conversation

ghost
Copy link

@ghost ghost commented Apr 17, 2017

Hi @gautamkrishnar.

I made few changes to the code as below:

  • .gitignore/ Added appropriate Python .gitignore.
  • socli/main.py : this is how main it should be called.
  • socli: there is no reason to call sys.exit, it will exit any way in the end of the function.

I will also suggest you to use regex instead of beautifulsoup library.
there is no complex HTML parsing

@gautamkrishnar
Copy link
Owner

Thanks for the PR @levisabah. Yes, i used beautifulsoup just for simplicity... 😄

Copy link
Owner

@gautamkrishnar gautamkrishnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG 👍

@gautamkrishnar gautamkrishnar merged commit dc119e4 into gautamkrishnar:master Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant