v0.9.1 #84
Merged
v0.9.1 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
gausby
commented
Aug 31, 2018
gausby
commented
- Fix a possible race condition when passively getting a connection for a publish. Fix Possible race condition when passively awaiting a connection #56
There was a small window when the process would register for a connection after it had gotten a the `:connecting` status from the registry; in this window the connection could be come available, and the pubsub would dispatch the connection before the registration happened, in which case it would reach the receive block too late. By setting up the connection subscription before checking the registry we can avoid this problem. We will then unregister the subscription after the function is done. The down side is that we will need to hit the ETS table every time we get a connection, but at least we will avoid processes timing out or even hanging forever when a connection is requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.