Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gatsby-plugin-eslint to eslint recipe so warnings/errors will print to CLI Learned this was necessary from this issue https://github.com/gatsbyjs/gatsby/issues/23666 #23674

Merged
merged 2 commits into from
May 1, 2020
Merged

Add gatsby-plugin-eslint to eslint recipe so warnings/errors will print to CLI Learned this was necessary from this issue https://github.com/gatsbyjs/gatsby/issues/23666 #23674

merged 2 commits into from
May 1, 2020

Conversation

KyleAMathews
Copy link
Contributor

No description provided.

@KyleAMathews KyleAMathews requested a review from a team as a code owner May 1, 2020 14:27
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 1, 2020
johno
johno previously approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖌️

@johno johno added topic: recipes bot: merge on green Gatsbot will merge these PRs automatically when all tests passes labels May 1, 2020
pvdz
pvdz suggested changes May 1, 2020
View reviewed changes
packages/gatsby-recipes/recipes/eslint.mdx Outdated

---

Write out a basic .eslintrc.js file that you can extend with your own choosen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typobot is correct...

@pvdz pvdz removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 1, 2020
@gatsbybot gatsbybot merged commit f722c6c into master May 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the eslint-recipe branch May 1, 2020 15:34
@muescha
Copy link
Contributor

muescha commented May 25, 2020

is #23666 is fixed with this PR?

@herecydev
Copy link
Contributor

Not really from my perspective. It would still be nice to add a few rules without copy/pasting gatsby's default ruleset.

This is important as those rules are adjusted over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herecydev herecydev herecydev left review comments

@pvdz pvdz pvdz approved these changes

@johno johno johno left review comments

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KyleAMathews @muescha @herecydev @pvdz @johno @gatsbybot