Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing comma in gatsby-transformer-remark README #23661

Merged
merged 1 commit into from
May 1, 2020

Conversation

martinlocklear
Copy link
Contributor

In the "How to use" section there is an example of what you might put in your gatsby-config.js file. There is a missing comma at the end of the timeToRead value.

(First pull request, hope I'm doing this right.)

Description

This simply adds the comma to the end of the line in the README example.

Documentation

This is a documentation only change.

In the "How to use" section there is an example of what you might put in your gatsby-config.js file.  There is a missing comma at the end of the `timeToRead` value.

(First pull request, hope I'm doing this right.)
@martinlocklear martinlocklear requested a review from a team as a code owner April 30, 2020 23:08
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 30, 2020
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @martinlocklear! Welcome and thanks for contributing! If you're feeling unsure, be sure to check out the Contributing docs as well as our open issues.

@AishaBlake AishaBlake merged commit c5ef71f into gatsbyjs:master May 1, 2020
@gatsbot
Copy link

gatsbot bot commented May 1, 2020

Holy buckets, @martinlocklear — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@AishaBlake AishaBlake added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants