Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-recipes): add local dev instructions for gatsby-recipes #23613

Merged
merged 12 commits into from
Apr 30, 2020
Merged

feat(gatsby-recipes): add local dev instructions for gatsby-recipes #23613

merged 12 commits into from
Apr 30, 2020

Conversation

KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Apr 29, 2020 •
edited
Loading

fixes #23604

@KyleAMathews KyleAMathews requested a review from a team as a code owner April 29, 2020 21:25
@KyleAMathews KyleAMathews self-assigned this Apr 29, 2020
@KyleAMathews KyleAMathews added this to In progress in Gatsby Recipes via automation Apr 29, 2020
Gatsby Recipes automation moved this from In progress to Reviewer approved Apr 29, 2020
johno
johno previously approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔖

laurieontech
laurieontech suggested changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions and a couple requests for clarification.

packages/gatsby-recipes/README.md Outdated Show resolved Hide resolved
packages/gatsby-recipes/README.md Outdated Show resolved Hide resolved
packages/gatsby-recipes/README.md Outdated Show resolved Hide resolved
packages/gatsby-recipes/README.md Outdated Show resolved Hide resolved
packages/gatsby-recipes/README.md Outdated Show resolved Hide resolved
packages/gatsby-recipes/README.md Outdated Show resolved Hide resolved
packages/gatsby-recipes/README.md Outdated Show resolved Hide resolved
packages/gatsby-recipes/README.md Outdated Show resolved Hide resolved
packages/gatsby-recipes/README.md Outdated Show resolved Hide resolved
packages/gatsby-recipes/README.md Outdated Show resolved Hide resolved
Gatsby Recipes automation moved this from Reviewer approved to Review in progress Apr 29, 2020
laurieontech
laurieontech previously approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Gatsby Recipes automation moved this from Review in progress to Reviewer approved Apr 30, 2020
Gatsby Recipes automation moved this from Reviewer approved to Review in progress Apr 30, 2020
@laurieontech laurieontech merged commit 0cab305 into master Apr 30, 2020
Gatsby Recipes automation moved this from Review in progress to Done Apr 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the dev-instructions branch April 30, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johno johno johno left review comments

@laurieontech laurieontech laurieontech left review comments

Assignees

@KyleAMathews KyleAMathews

Labels
None yet
Projects
No open projects
Gatsby Recipes
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add instructions for setting up a dev environment for recipes
3 participants
@KyleAMathews @johno @laurieontech