chore(docs): Tweak tsconfig for using typescript. #23596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AishaBlake
approved these changes
Apr 30, 2020
|
Merging as I've checked with Core in the past about reviewing code in |
ghost
reviewed
Jun 18, 2020
| @@ -2,7 +2,7 @@ | |||
| "include": ["./src/**/*"], | |||
| "compilerOptions": { | |||
| "target": "esnext", | |||
| "module": "commonjs", | |||
| "module": "esnext", | |||
There was a problem hiding this comment.
TypeScript compiler throws unless this is commonjs on Gatsby as of 2.23.4 (current release). Given this example is intended to help individuals get started with TypeScript the current setting leads to a poor DX:
There was a problem hiding this comment.
Hi @balibebas! would you be able to open a new issue for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tweaks some typescript settings to help avoid bundling issues.
Related Issues
closes #23595