refactor(www): refactor and simplify the sidebar #23248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor and simplify the logic of the sidebar.
Changes:
SidebarContext
to store common data so we don't have to keep passing down componentsAccordion
is now a function component whoseuid
is generated fromitem.title
.useCallback
in<Item>
used to scroll to the right item.isSingle
propTODO:
test the build to make sure everything actually worksPerf test: Make sure things remain "snappy". Adding context + memoization can cause things to become slow in unexpected ways.Motivation