Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polishing Plugin library #4394

Closed
16 tasks done
shannonbux opened this issue Mar 6, 2018 · 27 comments
Closed
16 tasks done

Polishing Plugin library #4394

shannonbux opened this issue Mar 6, 2018 · 27 comments
Assignees
Projects

Comments

@shannonbux
Copy link
Contributor

shannonbux commented Mar 6, 2018

Description

The plugin library is in dark deploy, thanks to @gillkyle and many others!
This fixes Issue #3003.

Next steps based off of discussions w/ @fk, @KyleAMathews, and @calcsam.
@KyleAMathews do these things?

  • Make sure deprecated packages are not appearing in plugin search
  • Support searching for gatsby-library in addition to gatsby-plugin and gatsby-component
  • Add "gatsby-plugin" keyword to package.json where missing
  • show total count of plugins w/o any search
  • script fetching all community plugins to find which ones aren't in the library and then PR adding keyword to them

@jlengstorf do this:

  • Template for plugin READme's ([docs] Add template for plugin READMEs #4284 thanks @jlengstorf) and can we make sure people know (possibly thru template and plugin instructions you wrote) that they need to use gatsby-plugin as a keyword, since Algolia search uses this?
  • Add instructions to the page for plugin authors about how to get their plugin to show up — namely
    • add "gatsby-plugin" as keyword
    • wait 24 hours while Algolia reindexes

@fk do this:

Shannon do this:

  • Figuring out where the plugin library ought to reside and how to navigate there on gatsbyjs.org ("Packages on top nav desktop and bottom nav in mobile) --> edit plugin docs page to redirect to packages library and plugin authoring page

Notes on possible future enhancements to the library:

  • Introduce filters (examples: filter by category, popularity, and what version of Gatsby the package works with)
  • For each plugin, include a list of open source websites from the showcase (and how many) that are using the plugin
@KyleAMathews
Copy link
Contributor

KyleAMathews commented Mar 8, 2018

Community plugins missing the "gatsby-plugin" keyword so not currently showing up in the search. Each one should have a PR adding either gatsby-plugin, gatsby-component, or gatsby-library as a keyword alampros/gatsby-plugin-accessibilityjs#1

Please check them off when you've made a PR!

@KyleAMathews
Copy link
Contributor

cc-ing repo owners if you want to fix things yourselves :-D @alampros @crgeary @julien1619 @didierfranc @marcobiedermann @dannywils @angeloocana @rongierlach @jlengstorf @kevzettler @Rulikkk @jcreamer898 @pixelstew @Jedidiah @angeloashmore @G100g @haysclark

kevzettler added a commit to kevzettler/gatsby-source-airtable that referenced this issue Mar 9, 2018
@jcreamer898
Copy link
Contributor

jcreamer898 commented Mar 9, 2018

Thanks for the heads up! Mine is updated.

jcreamer898 referenced this issue in jcreamer898/gatsby-plugin-typescript-css-modules Mar 9, 2018
G100g referenced this issue in G100g/gatsby-source-twitter Mar 9, 2018
@crgeary
Copy link
Contributor

crgeary commented Mar 9, 2018

Thanks! Mine gatsby-plugin-bugherd has been updated.

@youfoundron
Copy link
Contributor

The deed is done -- gatsby-plugin-purify-css

Rulikkk added a commit to Rulikkk/gatsby-remark-emoji that referenced this issue Mar 10, 2018
@Rulikkk
Copy link
Contributor

Rulikkk commented Mar 10, 2018

gatsby-remark-emoji updated with keywords. Thanks.

@dannywils
Copy link
Contributor

gatsby-plugin-meta-redirect has been updated

@fk
Copy link
Contributor

fk commented Mar 13, 2018

I added a PR #4472 'Replace main navigation item "Community" with "Plugins"' over the weekend, preview here: https://deploy-preview-4472--gatsbyjs.netlify.com/

@fk
Copy link
Contributor

fk commented Mar 14, 2018

@DirtyF
Copy link

DirtyF commented Mar 14, 2018

keyword added on https://github.com/didierfranc/gatsby-plugin-google-fonts

@DirtyF
Copy link

DirtyF commented Mar 14, 2018

@KyleAMathews all listed plugins have now a PR to add the missing keyword ✅

angeloocana pushed a commit to angeloocana/gatsby-plugin-i18n that referenced this issue Mar 14, 2018
Community plugins needs the "gatsby-plugin" keyword to show up in the search. 

see gatsbyjs/gatsby#4394 (comment)
@didierfranc
Copy link
Contributor

@DirtyF merged and published ;)

@jacobmischka
Copy link

@fk Will do!

@fk
Copy link
Contributor

fk commented Mar 15, 2018

Wow, thanks @DirtyF!
Thanks @jacobmischka!
🙏 🤗

jlengstorf pushed a commit to jlengstorf/gatsby-remark-numbered-footnotes that referenced this issue Mar 15, 2018
Community plugins needs the "gatsby-plugin" keyword to show up in the search. 

see gatsbyjs/gatsby#4394 (comment)
@angeloashmore
Copy link
Contributor

Merged PR into gatsby-node-helpers. Thanks @DirtyF!

@marcobiedermann
Copy link
Contributor

Merged in marcobiedermann/gatsby-plugin-svg-sprite#2 for gatsby-plugin-svg-sprite by @DirtyF

@lowmess
Copy link
Contributor

lowmess commented Mar 20, 2018

@jlengstorf Opened #4622 before seeing this issue and that the task was already on your roadmap. feel free to adjust/suggest wording or close the issue if it's not what was in mind.

@nihgwu
Copy link
Contributor

nihgwu commented Mar 20, 2018

I think we should support versioned plugin, I'm planning publish some of my own plugins but realize that they are for Gatsby V2

for example packages for Sublime Text
image

@m-allanson
Copy link
Contributor

@lowmess @jlengstorf I merged #4622 and checked it off at the top of this issue.

@shannonbux
Copy link
Contributor Author

@nihgwu Can you explain more about this? Do you mean you want the plugin library to show what version of Gatsby the plugin is compatible with?

@nihgwu
Copy link
Contributor

nihgwu commented Mar 21, 2018

@shannonbux exactly

@shannonbux
Copy link
Contributor Author

shannonbux commented Mar 21, 2018

@fk and @jlengstorf and @KyleAMathews Are your checklists at the top of this issue updated? Happy to help where I can.

ALSO Kyle, I just updated the long checklist of plugins to reflect that PR's have been made and/or merged for the entire list of plugins! Wait to go everyone.

@jlengstorf
Copy link
Contributor

@shannonbux I need to write the README template still, and I haven't done anything about the Algolia notes.

I also think we discussed keeping plugins instead of packages even though it's technically more than plugins.

Maybe those should be tracked in separate issues (the README already is) and close this?

@shannonbux
Copy link
Contributor Author

will do tomorrow! Thanks!

@KyleAMathews
Copy link
Contributor

Fun being able to regularly see the count of plugins now — we're already up 8-10 or so since we launched the library

@shannonbux
Copy link
Contributor Author

shannonbux commented Mar 23, 2018

@nihgwu Just created issue #4671 to add filters to plugin library, which would include version compatibility! Thanks!

@shannonbux
Copy link
Contributor Author

Ok closing this issue because I turned the remaining tasks into smaller issues in the UX project.

UX Project automation moved this from In progress to Done Mar 23, 2018
seniorprodev added a commit to seniorprodev/react_gatsby that referenced this issue Jul 31, 2022
Community plugins needs the "gatsby-plugin" keyword to show up in the search. 

see gatsbyjs/gatsby#4394 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
UX Project
  
Done
Development

No branches or pull requests