Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds @placebo_session decorator #41

Merged
merged 2 commits into from
Feb 26, 2016
Merged

Conversation

Miserlou
Copy link
Contributor

This adds the @placebo_session decorator mentioned in #40. Docs and test included.

This work is largely just done by @mathom - I'm just moving it upstream.

garnaat added a commit that referenced this pull request Feb 26, 2016
Adds @placebo_session decorator
@garnaat garnaat merged commit a7481a0 into garnaat:develop Feb 26, 2016
@garnaat
Copy link
Owner

garnaat commented Feb 26, 2016

Thanks!

@vascop
Copy link
Contributor

vascop commented Feb 28, 2016

Will this be pushed to pypi soon?

@garnaat
Copy link
Owner

garnaat commented Feb 28, 2016

Just pushed a 0.8.0

@vascop
Copy link
Contributor

vascop commented Feb 28, 2016

Thanks. I tried it and PLACEBO_DIR is going into __file__ which is wherever placebo is installed, in my case, my virtual environment. I also think that it should be configurable in some way. But definitely shouldn't be going into the virtual environment as a default.

@garnaat
Copy link
Owner

garnaat commented Feb 29, 2016

It seems like PLACEBO_DIR should be an environment variable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants