-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Hot Loader 2 #182
React Hot Loader 2 #182
Conversation
I made the switch on a project I'm currently in early stages on. Nothing broke, but reloading is noticably slower. I'll update this post if anything breaks. |
@mattconde Can you try |
@gaearon Yup thanks! That's done it. It's running now, I'll continue to test whilst I dev the app. |
@mattconde Thank you! |
Installing it gives me a warning which I think should not be ignored: npm WARN deprecated [email protected]: BROKEN NPM RELEASE. USE 0.5.0-alpha-2. |
@hmeerlo Thanks. I released |
Hmm, apparently 0.5.0-alpha-2 is not even available yet: No compatible version found: react-hot-api@'>=0.5.0-alpha-2 <0.6.0' |
@hmeerlo Bah, I forgot to publish it! Works now? |
Yes thanx, it works fine now. Not seeing any noticeable difference with the 1.x version btw. |
@hmeerlo That's good! 👍 Let me know if you find any problems. |
Installed the alpha-2 and everything seems to be working fine. The speed is relatively the same. |
alpha-2 has been working perfectly so far this morning! No noticeable speed difference. |
So far so good for me with |
@gaearon you might want to publish 2.0.0-alpha-X as a prerelease on npm rather than as the default latest release, so that it doesn't get installed when you run |
Damn. I was sure I published it as |
Shouldn't be RHL issue, right? If you put it before |
@gaearon Yep, sorry didn't mean to imply it was a bug, just a note for other redux users so they don't make the same dumb mistake. |
Working great so far 👍 |
Working great so far. In our case we were using |
Here's something new that came out of this. https://github.com/gaearon/react-transform-boilerplate |
Working great so far! Thanks a lot for a very seamless upgrade! 👍 Is there any ETA of stable release? Thanks! |
+1 for releasing this :) |
We’re skipping 2 but 3 might be coming eventually. 🍷 |
This PR tracks the work on modernizing React Hot Loader.
The Death of React Hot Loader should give you some idea. In short, we'll move as much as possible from RHL, possibly only keeping it as a brand. The actual implementation will be spread across React Proxy, a new, fully testable engine, and a few Babel plugins. In fact you can already take a glimpse at the approach we're likely to take in the future. It's still very raw, but enables scenarios which haven't been possible before with RHL.
Still, lots of projects use React Hot Loader as is, and before deprecating it in favor of something better, we want to port it to use React Proxy too as the new engine. In fact React Hot Loader users are the best possible testers for React Proxy, as their existing projects run on top of React Hot API it's meant to replace!
I'm releasing
[email protected]
on NPM now.It's not what React Hot Loader 2 will turn out to be—we don't know yet what it will be like. Right now, this alpha is just an internal change of engine, and I need you to test it, so that we know it's stable before we commit to using it in the React Hot Loader successor projects. What we want you to do is to install
[email protected]
and report your experience in this thread. Did something break in your app? Is hot reloading working subjectively better or worse, and why? If you're interested in the more detailed changes that React Proxy brings, along with caveats, check out the changelog entry.Thank you for helping me test
[email protected]
!