Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application/x-subrip alias for Srt #246

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Add application/x-subrip alias for Srt #246

merged 3 commits into from
Feb 7, 2022

Conversation

joksas
Copy link
Contributor

@joksas joksas commented Feb 3, 2022

Sorry to bother again. Would it be OK to add application/x-subrip alias for the SubRip format? My own motivation is this, and a quick search reveals it is used in many places, including the Android reference.

@coveralls
Copy link

coveralls commented Feb 3, 2022

Coverage Status

Coverage remained the same at 96.407% when pulling 0ac8c78 on joksas:application/x-subrip into bda98fd on gabriel-vasile:master.

@gabriel-vasile
Copy link
Owner

It seems like application/x-subrip is the most popular version for this MIME type. Besides the references you included, it is also mentioned here.

I think application/x-subrip should be the main MIME.

About the other three, text/x-subrip, text/x-srt, application/x-srt I'm not sure which ones to include.
Tbh, I don't have an unbiased process when choosing which MIMEs to add. If I see a MIME is mentioned a lot on the internet or used in some known program, then I include it. If it is only mentioned once, 20 years ago, by some obscure program/webpage then I skip it.

That being said, I'm going to list references I can find for each of them.

Feel free to include additional references and them we can make a decision.

@joksas
Copy link
Contributor Author

joksas commented Feb 4, 2022

Hi.

Looking at Google search results after 2010, I didn't find many other examples, except this for application/x-srt

In my opinion, text/x-srt and application/x-srt should be left in because they are used in a number of relatively popular projects. I am unsure about text/x-subrip as it is only used in one project. I don't have an opinion on this, so feel free to decide one or another way.

@gabriel-vasile
Copy link
Owner

Agree. text/x-subrip shall be left out.

@gabriel-vasile gabriel-vasile merged commit ac65698 into gabriel-vasile:master Feb 7, 2022
@joksas joksas deleted the application/x-subrip branch February 8, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants