Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group all queryby [bbox, drawpolygon, polygon] into a single map control #647

Merged
merged 641 commits into from
Sep 26, 2024
Merged

Group all queryby [bbox, drawpolygon, polygon] into a single map control #647

merged 641 commits into from
Sep 26, 2024

Conversation

volterra79
Copy link
Member

@volterra79 volterra79 commented Jul 11, 2024 •
edited
Loading

Depends on: #646

Supersedes: #599

Supersedes: #451

Before

image

After

Area controls are grouped under a single button:

Query by BBOX

image

Query by Draw Polygon

image

Query by Polygon

image

@volterra79 volterra79 added refactoring Anything which could result in a API change ux Changes to a current behavior to improve user experience labels Jul 11, 2024
@volterra79 volterra79 added this to the v3.11 milestone Jul 11, 2024
@volterra79 volterra79 self-assigned this Jul 11, 2024
@volterra79 volterra79 changed the title Gropus all queryby [bbox, drawpolygon, polygon] in on map control Group all queryby [bbox, drawpolygon, polygon] in on map control Jul 11, 2024
@Raruto Raruto changed the title Group all queryby [bbox, drawpolygon, polygon] in on map control Group all queryby [bbox, drawpolygon, polygon] into a single map control Jul 26, 2024
@Raruto Raruto marked this pull request as ready for review July 26, 2024 07:33
volterra79 added a commit to g3w-suite/g3w-admin that referenced this pull request Aug 16, 2024
@volterra79
✨ Client
5f697d1 
  g3w-suite/g3w-client#647
  g3w-suite/g3w-client-plugin-editing#121
volterra79 added a commit to g3w-suite/g3w-admin that referenced this pull request Aug 16, 2024
@volterra79
🚚 Client
e90b8e0 
  g3w-suite/g3w-client#647
Raruto
Raruto reviewed Aug 19, 2024
View reviewed changes
src/services/iframe.js Outdated Show resolved Hide resolved
volterra79 added a commit that referenced this pull request Aug 19, 2024
@volterra79
https://github.com/g3w-suite/g3w-client/pull/647#pullrequestreview-22…
01496c5 
…44681101
volterra79 added a commit to g3w-suite/g3w-admin that referenced this pull request Aug 20, 2024
@volterra79
⬆️ Client
d53f476 
  g3w-suite/g3w-client#647 - Query by Circle
volterra79 added a commit to g3w-suite/g3w-admin that referenced this pull request Aug 20, 2024
@volterra79
⬆️ Client
dd459ac 
  g3w-suite/g3w-client#647 - Clear radius button
volterra79 added a commit to g3w-suite/g3w-admin that referenced this pull request Aug 22, 2024
@volterra79
⬆️ Client
2ae332b 
  g3w-suite/g3w-client#647 - sidebar
  https://github.com/g3w-suite/g3w-client-plugin-qplotly/ - aligned with v3.11.0 g3w-client
volterra79 and others added 15 commits August 23, 2024 12:04
@volterra79
Remove duplicate added by merge
c9e8928
@volterra79
Wrong reference due merge
5872c12
@volterra79
Replace d.resolve with resolve due merge
233fdf8
@volterra79
use GUI.getService
2b9aeb7
@Raruto
remove unusued stuff
05a81e5
@Raruto
Merge branch 'group-queryby-controls' of https://github.com/g3w-suite…
3a5eb52 
…/g3w-client into group-queryby-controls
@Raruto
wrong context
596d557
@Raruto
replace: state.components → GUI.getComponent()
0b20ee6
@volterra79
Use reactive state vue. Need to fix showPanel on sidebar
4a9e50d
@volterra79
Remove push
9c76793
@volterra79
use import { $promisify, promisify } from 'utils/promisify' instead $…
254dc2b 
….Deferred
@volterra79
use import { $promisify } from 'utils/promisify' instead $.Deferred
49f9975
@volterra79
use import { $promisify } from 'utils/promisify' instead $.Deferred
1e7a677
@volterra79
use import { $promisify } from 'utils/promisify' instead $.Deferred
c410e08
@volterra79
use import { $promisify } from 'utils/promisify' instead $.Deferred
e6283ba
Raruto and others added 28 commits September 20, 2024 09:09
@Raruto
wrong merge
9dcf9e8
@Raruto
move v-tooltip to parent container
484970e
@volterra79
Show tooltip on sidebar item only when sidebar is collapsed
edb696b
@volterra79
Remove skin color to v-t-tooltip
1da73dc
@volterra79
Dynamic tooltip on tool
69d6b80
@Raruto
update css
e645076
@Raruto
Merge branch 'group-queryby-controls' of https://github.com/g3w-suite…
f9a0cac 
…/g3w-client into group-queryby-controls
@Raruto
useful: :current-tooltip
f7db2a6
@volterra79
🐛 In case of layer title with strange character, fix show title on co…
6f4201a 
…ntext
@Raruto
left align map control tooltips
a01d9f4
@volterra79
🐛 Hide tooltip when current-tooltip is null or empty
ecdca55
@volterra79
Merge remote-tracking branch 'origin/group-queryby-controls' into gro…
184acfe 
…up-queryby-controls
@volterra79
🐛 :Bug: Show error message in case of error when zoom to layer. It ca…
3a579ed 
…n happen if strange bbox is set by server to layer
@Raruto
remove ApiService
5280344
@volterra79
Clena code - space and console.log removed
f6e4733
@volterra79
🐛 Change layer position
f259ae7
@volterra79
🐛 emit event change position instead change position pros directly
544fa59
@Raruto
remove directives/v-selected-first.js
89b5947
@Raruto
remove directives/v-plugins.js
c411990
@Raruto
remove directives/v-online.js
d16c50e
@Raruto
simplify v-disabled
9327097
@volterra79
🐛 return state
338fed0
@volterra79
Clean code - spaces
3f1602c
@volterra79
Clean code - spaces
7a1c62a
@volterra79
Clean code - readability
35d3d69
@volterra79
🐛 Shor layers result sort by TOC layers order
c0399d1
@volterra79
🐛 Missing ARCGISMAPSERVER base layer
59966c9
@Raruto
remove v-t-placeholder
36091eb
@volterra79 volterra79 merged commit d3fd48f into dev Sep 26, 2024
@volterra79 volterra79 deleted the group-queryby-controls branch September 26, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raruto Raruto Raruto approved these changes

Assignees

@volterra79 volterra79

Labels
refactoring Anything which could result in a API change ux Changes to a current behavior to improve user experience
Projects
None yet
Milestone
v3.11
Development

Successfully merging this pull request may close these issues.
2 participants
@volterra79 @Raruto