Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix SameSite cookie property. #793

Merged
merged 6 commits into from
Apr 30, 2024
Merged

🐛 Fix SameSite cookie property. #793

merged 6 commits into from
Apr 30, 2024

Conversation

wlorenzetti
Copy link
Member

Closes: #791

@wlorenzetti wlorenzetti added bug Something isn't working backport to v.3.7.x labels Mar 25, 2024
@wlorenzetti wlorenzetti added this to the v3.8 milestone Mar 25, 2024
@wlorenzetti wlorenzetti requested a review from Raruto March 25, 2024 14:08
@wlorenzetti wlorenzetti self-assigned this Mar 25, 2024
@wlorenzetti wlorenzetti marked this pull request as ready for review March 25, 2024 14:08
@Raruto Raruto mentioned this pull request Mar 26, 2024
Closed
1 task
Raruto
Raruto reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@Raruto Raruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wlorenzetti maybe you missed: #791 (comment)

@wlorenzetti
Copy link
Member Author

@wlorenzetti maybe you missed: #791 (comment)

No I'll check after

Raruto
Raruto reviewed Apr 9, 2024
View reviewed changes
g3w-admin/client/views.py Outdated Show resolved Hide resolved
@Raruto Raruto changed the title Fix SameSite cookie property. 🐛 Fix SameSite cookie property. Apr 18, 2024
@wlorenzetti wlorenzetti merged commit d9d8bde into dev Apr 30, 2024
4 checks passed
@wlorenzetti wlorenzetti deleted the fix_cookie branch April 30, 2024 05:39
github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
@wlorenzetti @github-actions
🐛 Fix SameSite cookie property. (#793)
7d494bf 
* Fix `SameSite` cookie property.

* Fix samesite value.

* Add secure=True for samesite=None

---------

Co-authored-by: wlorenzetti <[email protected]>
Co-authored-by: Raruto <[email protected]>
(cherry picked from commit d9d8bde)
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Merged
wlorenzetti added a commit that referenced this pull request Apr 30, 2024
@github-actions @wlorenzetti
🐛 Fix SameSite cookie property. (#793) (#835)
b694caa 
* Fix `SameSite` cookie property.

* Fix samesite value.

* Add secure=True for samesite=None

---------

Co-authored-by: wlorenzetti <[email protected]>
Co-authored-by: Raruto <[email protected]>
(cherry picked from commit d9d8bde)

Co-authored-by: Walter Lorenzetti <[email protected]>
wlorenzetti added a commit that referenced this pull request May 6, 2024
@wlorenzetti @Raruto
🐛 Fix SameSite cookie property. (#793)
a7776be 
* Fix `SameSite` cookie property.

* Fix samesite value.

* Add secure=True for samesite=None

---------

Co-authored-by: wlorenzetti <[email protected]>
Co-authored-by: Raruto <[email protected]>
wlorenzetti added a commit that referenced this pull request May 20, 2024
@wlorenzetti @Raruto @volterra79
Add 'other_info' (userdata) to user form. (#832)
270c031 
* Add 'other_info' (userdata) to user form.

* ✨ Allow to store custom map themes (authenticathed users) (#813)

* Create model for customer themes.

* Implemented CRUD custom theme.

* Add constraint.

* Typo

* Add invalidation of project cache.

* Fix test.

* Remove CSFR check.

* ✨ Client
  g3w-suite/g3w-client@0e226b2

* 🐛 Client
  g3w-suite/g3w-client@37adf60

* Add pydantic validation data structure.

---------

Co-authored-by: wlorenzetti <[email protected]>
Co-authored-by: volterra79 <[email protected]>
Co-authored-by: Raruto <[email protected]>

* 🐛 Fix `SameSite` cookie property. (#793)

* Fix `SameSite` cookie property.

* Fix samesite value.

* Add secure=True for samesite=None

---------

Co-authored-by: wlorenzetti <[email protected]>
Co-authored-by: Raruto <[email protected]>

* ✨ Client
  g3w-suite/g3w-client@19c1d71

* ⚡ Client
   g3w-suite/g3w-client@dc02f92

* Fix issue #838

---------

Co-authored-by: wlorenzetti <[email protected]>
Co-authored-by: Raruto <[email protected]>
Co-authored-by: volterra79 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raruto Raruto Raruto left review comments

Assignees

@wlorenzetti wlorenzetti

Labels
backport to v.3.7.x bug Something isn't working
Projects
None yet
Milestone
v3.8
Development

Successfully merging this pull request may close these issues.

Cookie “g3wclientsessiontoken” does not have a proper “SameSite” attribute value.
2 participants
@wlorenzetti @Raruto