Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Several fixes to the build system #189

Merged
merged 4 commits into from
May 4, 2014
Merged

cmake: Several fixes to the build system #189

merged 4 commits into from
May 4, 2014

Conversation

ghost
Copy link

@ghost ghost commented Apr 15, 2014

  • Install the FindGLM cmake script so it will work out of the box for downstream users
  • Don't build the tests unless testing is enabled; this removes the need to abort cmake (which prevents running "make install" or any other targets)
  • Use standard install paths

I'm not familiar with the cmake git branches, so if this needs rebasing onto any other branches, just let me know.

@Groovounet Groovounet added this to the GLM 0.9.5 milestone May 4, 2014
@Groovounet Groovounet self-assigned this May 4, 2014
Groovounet added a commit that referenced this pull request May 4, 2014
cmake: Several fixes to the build system #189
@Groovounet Groovounet merged commit 0cbef58 into g-truc:0.9.5 May 4, 2014
Groovounet pushed a commit that referenced this pull request May 4, 2014
@Groovounet
Copy link
Member

The proposed changes looks great and will makes it for GLM 0.9.5.4 branch,

Thanks for contributing!
Christophe

@ghost ghost deleted the cmake-install branch May 4, 2014 19:45
@JPGygax68
Copy link

I'm working under Windows, using GLM version 0.9.5.4. I think FindGLM.cmake gets installed to the wrong directory here; it goes to ${CMAKE_INSTALL_PREFIX}/lib/cmake, where CMake can't find it by itself. According to http:https://www.cmake.org/cmake/help/v3.0/command/find_package.html, the suffix lib/cmake is valid for Linux, but not for Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants