Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: declarations #1132

Merged
merged 1 commit into from
Jan 13, 2023
Merged

fix: declarations #1132

merged 1 commit into from
Jan 13, 2023

Conversation

gottfriedleibniz
Copy link

Inspecting the symbols of a library using glm (compiled w/ default visibility) lead me to notice these being externalized:

unsigned int glm::findEigenvaluesSymReal<2, float, (glm::qualifier)3>(glm::mat<2, 2, float, (glm::qualifier)3> const&, glm::vec<2, float, (glm::qualifier)3>&, glm::mat<2, 2, float, (glm::qualifier)3>&)
unsigned int glm::findEigenvaluesSymReal<3, float, (glm::qualifier)3>(glm::mat<3, 3, float, (glm::qualifier)3> const&, glm::vec<3, float, (glm::qualifier)3>&, glm::mat<3, 3, float, (glm::qualifier)3>&)
unsigned int glm::findEigenvaluesSymReal<4, float, (glm::qualifier)3>(glm::mat<4, 4, float, (glm::qualifier)3> const&, glm::vec<4, float, (glm::qualifier)3>&, glm::mat<4, 4, float, (glm::qualifier)3>&)
glm::mat<2, 2, float, (glm::qualifier)3> glm::computeCovarianceMatrix<2, float, (glm::qualifier)3, ...
glm::mat<2, 2, float, (glm::qualifier)3> glm::computeCovarianceMatrix<2, float, (glm::qualifier)3, ...
glm::mat<3, 3, float, (glm::qualifier)3> glm::computeCovarianceMatrix<3, float, (glm::qualifier)3, ...
glm::qua<float, (glm::qualifier)0> glm::toQuat<float, (glm::qualifier)0>(glm::mat<4, 4, float, (glm::qualifier)0> const&)
glm::qua<float, (glm::qualifier)3> glm::toQuat<float, (glm::qualifier)3>(glm::mat<3, 3, float, (glm::qualifier)3> const&)

This commit fixes the declarations to the listed functions.

Copy link

@christophe-lunarg christophe-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@christophe-lunarg christophe-lunarg merged commit d58d06b into g-truc:master Jan 13, 2023
@gottfriedleibniz gottfriedleibniz deleted the fix/exports branch January 13, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants