Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: spelling, grammar, and clarity #1109

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

EbiSadeghi
Copy link

Modified Readme to fix some typos.
Modified HTML doc to make function description more accurate.

Minor grammar and spelling.
The description of the function "exp" erroneously referred to "x" rather than "v". Rectified.
@@ -89,7 +89,7 @@
Functions</h2></td></tr>
<tr class="memitem:ga071566cadc7505455e611f2a0353f4d4"><td class="memTemplParams" colspan="2">template&lt;length_t L, typename T , qualifier Q&gt; </td></tr>
<tr class="memitem:ga071566cadc7505455e611f2a0353f4d4"><td class="memTemplItemLeft" align="right" valign="top">GLM_FUNC_DECL vec&lt; L, T, Q &gt;&#160;</td><td class="memTemplItemRight" valign="bottom"><a class="el" href="a00242.html#ga071566cadc7505455e611f2a0353f4d4">exp</a> (vec&lt; L, T, Q &gt; const &amp;v)</td></tr>
<tr class="memdesc:ga071566cadc7505455e611f2a0353f4d4"><td class="mdescLeft">&#160;</td><td class="mdescRight">Returns the natural exponentiation of x, i.e., e^x. <a href="a00242.html#ga071566cadc7505455e611f2a0353f4d4">More...</a><br /></td></tr>
<tr class="memdesc:ga071566cadc7505455e611f2a0353f4d4"><td class="mdescLeft">&#160;</td><td class="mdescRight">Returns the natural exponentiation of v, i.e., e^v. <a href="a00242.html#ga071566cadc7505455e611f2a0353f4d4">More...</a><br /></td></tr>
Copy link

@Tachi107 Tachi107 Sep 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of the doc/api/ directory is generated by Doxygen; you should fix the comment in the actual source, and then regenerate the documentation. The typo is here:

/// Returns the natural exponentiation of x, i.e., e^x.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out. I'll change it under glm/glm/exponential.hpp as you pointed out.

Earlier I made the change in the html generated by doxygen rather than the source used to generate the documentation.
@christophe-lunarg christophe-lunarg self-assigned this Oct 24, 2022
@christophe-lunarg christophe-lunarg merged commit e250ffe into g-truc:master Oct 24, 2022
@christophe-lunarg
Copy link

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants