Adding constexpr qualifier for helper functions #1050
Conversation
lessThan, lessThanEqual, greaterThan, greaterThanEqual
mix(scalar, scalar), mix(vec, vec, vec), mix(vec,vec,scalar)
Default ctor used in constexpr contex generates warning on gcc
|
I don't think that my code failed tests. |
|
Would you mind to rebase your commit to master branch that is fixed? |
|
Of course, I'll do it later. Have a nice holidays! |
lessThan, lessThanEqual, greaterThan, greaterThanEqual
mix(scalar, scalar), mix(vec, vec, vec), mix(vec,vec,scalar)
Default ctor used in constexpr contex generates warning on gcc
| @@ -91,7 +91,7 @@ namespace detail | |||
| template<length_t L, typename T, qualifier Q, bool Aligned> | |||
| struct compute_mix_vector<L, T, bool, Q, Aligned> | |||
| { | |||
| GLM_FUNC_QUALIFIER static vec<L, T, Q> call(vec<L, T, Q> const& x, vec<L, T, Q> const& y, vec<L, bool, Q> const& a) | |||
| GLM_FUNC_QUALIFIER GLM_CONSTEXPR static vec<L, T, Q> call(vec<L, T, Q> const& x, vec<L, T, Q> const& y, vec<L, bool, Q> const& a) | |||
| { | |||
| vec<L, T, Q> Result; | |||
There was a problem hiding this comment.
This seems to be failing the GCC6 C++14 builds in Travis. I think it's the C++14 vs C++17 discrepancy in what's allowed inside constexpr functions. This StackOverflow issue sheds some extra light: https://stackoverflow.com/questions/41618576/what-is-allowed-in-a-constexpr-function
In this case, Result should be initialized.
There was a problem hiding this comment.
Yes, I've seen it. My bad. I'll fix it this evening.
|
The only way to init the result variable is |
|
Hi, |
|
I created a new PR #1184 to run the unit tests Thanks for contributing! |
* Adding constexpr for exterior product * Adding constexpr for conjugate * Adding constexpr for dot, cross and inverse quaternion functions * Adding constexpr for quat lerp * Adding constexpr to quaternion comparison functions lessThan, lessThanEqual, greaterThan, greaterThanEqual * Adding constexpr for mix functions mix(scalar, scalar), mix(vec, vec, vec), mix(vec,vec,scalar) * Adding constexpr for sign(vec) and sign(genFIType) * Initialize result lessThan, lessThanEqual, greaterThan, greaterThanEqual Default ctor used in constexpr contex generates warning on gcc * Adding constexpr to cross(vec, qua) and cross(qua, vec) * Adding constexpr to glm::translate * Adding constexpr for exterior product * Adding constexpr for conjugate * Adding constexpr for dot, cross and inverse quaternion functions * Adding constexpr for quat lerp * Adding constexpr to quaternion comparison functions lessThan, lessThanEqual, greaterThan, greaterThanEqual * Adding constexpr for mix functions mix(scalar, scalar), mix(vec, vec, vec), mix(vec,vec,scalar) * Adding constexpr for sign(vec) and sign(genFIType) * Initialize result lessThan, lessThanEqual, greaterThan, greaterThanEqual Default ctor used in constexpr contex generates warning on gcc * Adding constexpr to cross(vec, qua) and cross(qua, vec) * Adding constexpr to glm::translate --------- Co-authored-by: RohacekD <[email protected]>
constexprqualifier forvec sign(vec)functionconstexprqualifier formix(scalar, scalar, scalar),mix(vec, vec, scalar),mix(vec, vec, vec)functionsconstexprqualifier format translate(mat, vec)functionconstexprqualifier forqua lerp(qua, qua, scalar a)functionconstexprqualifier forqua conjugate(qua)functionconstexprqualifier forqua inverse(qua)functionconstexprqualifier forscalar dot(qua, qua)functionconstexprqualifier forqua cross(qua, qua)functionconstexprqualifier forvec<bool> lessThan(qua, qua)functionconstexprqualifier forvec<bool> lessThanEqual(qua, qua)functionconstexprqualifier forvec<bool> greaterThan(qua, qua)functionconstexprqualifier forvec<bool> greaterThanEqual(qua, qua)functionconstexprqualifier forvec<bool> greaterThanEqual(qua, qua)functionconstexprqualifier forexterior_productfunctionconstexprqualifier forvec3 cross(qua, vec)functionconstexprqualifier forvec3 cross(vec, qua)functionI tried functions in constexpr context and had no errors. I had to do a small change in comparison functions to avoid warning about default constructed object by initialising results to
false.Falsevalues will be rewritten by following for cycles but GCC complained anyway.