Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial issue in tweakedInfinitePerspective method #208

Closed
EvilMax opened this issue May 25, 2014 · 1 comment
Closed

Trivial issue in tweakedInfinitePerspective method #208

EvilMax opened this issue May 25, 2014 · 1 comment
Assignees
Labels
Milestone

Comments

@EvilMax
Copy link

EvilMax commented May 25, 2014

Tweaked algorithm which calculates infinite perspective matrix has a trivial issue: one of the matrix elements is calculated incorrectly (with wrong sign).

Here it is what we have:
Result[3][2] = - (T(0.0001) - T(2)) * zNear;

And here it is what should be:
Result[3][2] = (T(0.0001) - T(2)) * zNear;

Just remove minus to fix this.

@Groovounet Groovounet added the bug label Jun 20, 2014
@Groovounet Groovounet added this to the GLM 0.9.5 milestone Jun 20, 2014
@Groovounet Groovounet self-assigned this Jun 20, 2014
Groovounet pushed a commit that referenced this issue Jun 20, 2014
@Groovounet
Copy link
Member

This issue is fixed in GLM 0.9.5 branch for GLM 0.9.5.4 release.

Thanks for contributing!
Christophe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants