Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLM_ARCH_SSE4 is not defined. #204

Closed
mackron opened this issue May 21, 2014 · 2 comments
Closed

GLM_ARCH_SSE4 is not defined. #204

mackron opened this issue May 21, 2014 · 2 comments
Assignees
Labels
Milestone

Comments

@mackron
Copy link

mackron commented May 21, 2014

For some reason it appears the GLM_ARCH_SSE4 define is left out in setup.hpp. Not a huge problem, except simd_quat has an SSE4 optimized path which of causes -Wundef warnings.

I can remove that optimized path from simd_quat, but using GLM for platform detection for my own code is pretty handy - it'd be nice to have GLM_ARCH_SSE4 available too.

@Groovounet Groovounet added the bug label May 21, 2014
@Groovounet Groovounet added this to the GLM 0.9.5 milestone May 21, 2014
@Groovounet Groovounet self-assigned this May 21, 2014
@Groovounet
Copy link
Member

Ok, I can fix it.

I guess the reasoning here was that SSE, SSE2, SSE3 were clean set of cross platform instruction sets. SSSE3 SSE4* not so much.

So in GLM the idea was to just ignore SSE after SSE3 and check for AVX that is also a clean cross platform instruction set that have all the SSE4 stuff.

That doesn't prevent introducing SSE4 again if that's useful.

Groovounet pushed a commit that referenced this issue May 23, 2014
@Groovounet
Copy link
Member

This is fixed in GLM 0.9.5 branch for GLM 0.9.5.4 release.

Thanks for contributing,
Christophe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants