Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color_space - saturation #195

Closed
dmaluev opened this issue Apr 27, 2014 · 1 comment
Closed

color_space - saturation #195

dmaluev opened this issue Apr 27, 2014 · 1 comment
Assignees
Labels
Milestone

Comments

@dmaluev
Copy link

dmaluev commented Apr 27, 2014

color_space.inl no longer compiles in Visual Studio

template <typename T, precision P>
GLM_FUNC_QUALIFIER detail::tvec3<T, P> saturation(const T s, const detail::tvec3<T, P>& color)
{
return detail::tvec3<T, P>(saturation(s) * detail::tvec4<T, P>(color, T(0)));
}

it cannot detect that 'saturation(s)' is actually
detail::tmat4x4<T, P> saturation(const T s)
probably because parameter P is not provided

Groovounet pushed a commit that referenced this issue May 4, 2014
@Groovounet Groovounet added the bug label May 4, 2014
@Groovounet Groovounet added this to the GLM 0.9.5 milestone May 4, 2014
@Groovounet Groovounet self-assigned this May 4, 2014
@Groovounet
Copy link
Member

This issue has been fixed in GLM 0.9.5 branch for GLM 0.9.5.4 release.

Thanks for reporting!
Christophe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants