Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No unused function result warning #1217

Closed
esnosy opened this issue Jan 15, 2024 · 3 comments · Fixed by #1252
Closed

No unused function result warning #1217

esnosy opened this issue Jan 15, 2024 · 3 comments · Fixed by #1252
Labels
enhancement OS: Platform independent

Comments

@esnosy
Copy link

esnosy commented Jan 15, 2024

I'm using glm::rotate, and if I forget to use the function result somewhere in my code, the error is silent, the results will be wrong,

marking glm::rotate as [[nodiscard]] fixes it, but that needs to be done for all similar functions
@christophe-lunarg
Copy link

I like this feature request, I'll try to implement it someday soon (TM)!

christophe-lunarg added a commit that referenced this issue Feb 8, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
d22f530
@christophe-lunarg christophe-lunarg linked a pull request Feb 8, 2024 that will close this issue
Add C++ 17 no discard support #1252
Merged
@esnosy
Copy link
Author

esnosy commented Feb 9, 2024 •
edited
Loading

That was quick, thanks a ton for awesome work ☺️☺️🤍

christophe-lunarg added a commit that referenced this issue Feb 9, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
0ce1ceb
christophe-lunarg added a commit that referenced this issue Feb 9, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
f15198e
christophe-lunarg added a commit that referenced this issue Feb 9, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
7db132b
christophe-lunarg added a commit that referenced this issue Feb 9, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
43daa6b
christophe-lunarg added a commit that referenced this issue Feb 9, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
57ed388
christophe-lunarg added a commit that referenced this issue Feb 9, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
85b951b
christophe-lunarg added a commit that referenced this issue Feb 9, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
311d546
christophe-lunarg added a commit that referenced this issue Feb 9, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
7c724bb
christophe-lunarg added a commit that referenced this issue Feb 9, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
6050d8e
christophe-lunarg added a commit that referenced this issue Feb 9, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
a2fae88
christophe-lunarg added a commit that referenced this issue Feb 9, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
4edfdc6
christophe-lunarg added a commit that referenced this issue Feb 9, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
0e6ddde
christophe-lunarg added a commit that referenced this issue Feb 10, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
6d81506
christophe-lunarg added a commit that referenced this issue Feb 10, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
b43959d
christophe-lunarg added a commit that referenced this issue Feb 10, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
6912fbc
christophe-lunarg added a commit that referenced this issue Feb 10, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
9b3ce7e
christophe-lunarg added a commit that referenced this issue Feb 10, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
13044d6
christophe-lunarg added a commit that referenced this issue Feb 10, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
ff62f3b
@christophe-lunarg
Copy link

That was quick, thanks a ton for awesome work ☺️☺️🤍

It's probably not exaustive but future contributions would be welcome!

christophe-lunarg added a commit that referenced this issue Feb 10, 2024
@christophe-lunarg
Added C++17 [[nodiscard]] support #1217
5d73e17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement OS: Platform independent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add C++ 17 no discard support g-truc/glm
2 participants
@esnosy @christophe-lunarg