Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example tab on pub.dev and remove low-quality dependency #1263

Merged
merged 7 commits into from
Jun 30, 2023

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jun 29, 2023

Changes

Close #1260
Close #1262

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. End-to-end tests are usually in the ./frb_example/pure_dart example, more specifically, rust/src/api.rs and dart/lib/main.dart.
  • The code generator is run and the code is formatted (via just precommit).
  • If this PR adds/changes features, documentations (in the ./book folder) are updated.
  • CI is passing.

Remark for PR creator

  • Justfile is a task runner for the command line interface that allows you to run shell commands from a file named justfile in your project directory. You can use Justfile after installing it. Note that commands written in justfile of this repository are expected to be run in bash, not cmd or powershell. Running just ... commands in cmd or powershell will produce errors as the syntax is not compatible. On Windows, you can use git bash if you have Git installed.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy
Copy link
Owner Author

fzyzcjy commented Jun 29, 2023

(would like to discuss #1261 (comment) before further implementation)

@fzyzcjy fzyzcjy marked this pull request as ready for review June 30, 2023 12:47
@fzyzcjy fzyzcjy changed the title Improve Dart quality Update example tab on pub.dev and remove low-quality dependency Jun 30, 2023
@fzyzcjy fzyzcjy merged commit c0e2280 into master Jun 30, 2023
@fzyzcjy fzyzcjy deleted the feat/dart-convention branch June 30, 2023 14:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible low quality dependencies example tab on pub.dev
1 participant