algoltek-aux: Disable the plugin until we can do a DPCD check #7378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superm1
reviewed
Jun 21, 2024
Comment on lines
+1
to
+2
| #[MST\VEN_25A4&DEV_AG9421] | ||
| #Plugin = algoltek-aux |
There was a problem hiding this comment.
Rather than do this can't @YiJaneWu share the right values for fu_dpaux_device_get_dpcd_dev_id()?
There was a problem hiding this comment.
Currently we don't have a value set in it. Is this necessary to set value for fu_dpaux_device_get_dpcd_dev_id()?
There was a problem hiding this comment.
@YiJaneWu it's causing problems for other plugins because they all try to probe in your plugin. For example I see on one system on my end:
Loading… [***** ]03:24:53.883 FuEngine no GUIDs for device ZynqMP DP AUX [1e95e9045ae167af37a77a1df296b8d60dd4af7d]
There was a problem hiding this comment.
So; yes if you can still set a value for the DPCD in your firmware, please do so and fix the plugin to use it.
There was a problem hiding this comment.
OK, we will plan to use OUI or set device ID in our firmware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7376
Type of pull request: