Weida/raw

[hughsie]

Type of pull request:

• New plugin (Please include new plugin checklist)
• Code fix
• Feature
• Documentation

[hughsie]

@randytry @chenhn123 -- I've added a couple of fixups -- can you test to see if I've broken anything?

[chenhn123]

I see
https://github.com/fwupd/fwupd/tree/weida/raw

[hughsie]

I see https://github.com/fwupd/fwupd/tree/weida/raw

Yup, lets collaborate on that weida/raw branch.

[chenhn123]

Hi Maintainer,
I modify for offset issue and update the firmware success.
But I found some message after the parsing and update the firmware
"base stream was 0x1ed24 bytes in size, and tried to create partial stream @0x1e5e4 of 0x758 bytes"
Is there anything wrong with this?

[hughsie]

@chenhn123 I suspect we need to fix FIXME: should we create a partial stream based on the payload length? -- can you send me an example firmware so I can do that for you? Either attach here or send to richard_at_hughsie_dot_com -- thanks.

[chenhn123]

WDT8761A_DUMMY.zip

[randytry]

the wif has two chunk one chunk FRWR is start at address 0x30000 and length is 0x2000
and the other chunk CNFG is start at address 0x51000 and length is 0x1000

[hughsie]

@chenhn123 @randytry -- much appreciated, thanks. This now gives:

[hughsie@hughsie-work-lan build (weida/raw %)]$ ninja && ./src/fwupdtool firmware-parse WDT8761A_DUMMY.wif weida-raw
<firmware gtype="FuWeidaRawFirmware">
  <flags>has-stored-size</flags>
  <data size="0x3068">[GInputStream]</data>
  <firmware>
    <id>frwr</id>
    <addr>0x30000</addr>
    <offset>0x48</offset>
    <data size="0x2000">[GInputStream]</data>
  </firmware>
  <firmware>
    <id>cnfg</id>
    <addr>0x51000</addr>
    <offset>0x2068</offset>
    <data size="0x1000">[GInputStream]</data>
  </firmware>
</firmware>

I've pushed a fixup, does that work?

[chenhn123]

I think you got the most of thing in this format,
but we had define something prefix(but not used) byte
so we need to start program form exclude the prefix
If the firmware is updated excepted flash map is :

but I got

[hughsie]

Something like ^^^ perhaps?

[chenhn123]

Okay, it work well and correct.
but I can't get what is "Something like ^^^ perhaps?" mean ?

[hughsie]

Okay, it work well and correct.

That's great; can you comment on some of the TODOs and FIXMEs please? I've rebased against master and force-pushed the branch with all the fixups so far.

[chenhn123]

Could you please give me some sample of TODOs and FIXMEs ?

[hughsie]

Could you please give me some sample of TODOs and FIXMEs ?

Sure -- all in the .c file, e.g. https://github.com/fwupd/fwupd/blob/weida/raw/plugins/weida-raw/fu-weida-raw-device.c#L538