Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call hazeList from main and huge refactor #151

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Call hazeList from main and huge refactor #151

merged 1 commit into from
Feb 17, 2023

Conversation

cchriss123
Copy link
Contributor

@cchriss123 cchriss123 commented Feb 17, 2023 •
edited
Loading

Add main test for hazelList, huge refactor of hazeList and hazeList tests.

@cchriss123 @jLereback
Huge refactor
88210e3 
Co-authored-by: Julia Lerebäck Corell <[email protected]>
@cchriss123 cchriss123 linked an issue Feb 17, 2023 that may be closed by this pull request
HazeLists need to be correctly called #101
Closed
@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

91.0% 91.0% Coverage
0.0% 0.0% Duplication

@cchriss123 cchriss123 added the enhancement New feature or request label Feb 17, 2023
@cchriss123 cchriss123 changed the title Huge refactor Call hazeList from main and huge refactor Feb 17, 2023
figgge
figgge approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@figgge figgge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

RobertMili
RobertMili approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@RobertMili RobertMili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested in it Scratch, and it worked for me. Good job

@cchriss123 cchriss123 added this pull request to the merge queue Feb 17, 2023
Merged via the queue into main with commit 0550066 Feb 17, 2023
@jLereback jLereback deleted the 101-hazelists-need-to-be-correctly-called-2 branch February 17, 2023 12:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertMili RobertMili RobertMili approved these changes

@figgge figgge figgge approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HazeLists need to be correctly called
4 participants
@cchriss123 @RobertMili @figgge @kappsegla