Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not prevent single-read or single-write above rate limit #4

Open
sbward opened this issue Aug 28, 2019 · 0 comments
Open

Does not prevent single-read or single-write above rate limit #4

sbward opened this issue Aug 28, 2019 · 0 comments

Comments

@sbward
Copy link
Contributor

sbward commented Aug 28, 2019

If a single read or write exceeds the amount specified in the rate limit, then nothing stops that read or write from exceeding the rate limit.

For example, if I set rate limit to 1KB/s, and I Write a 2KB []byte, then the full 2KB will be written immediately.

I think this library should try to measure the incoming read or write sizes and buffer them out to achieve the rate limit.

viciious added a commit to viciious/shapeio that referenced this issue Jan 24, 2023
viciious added a commit to viciious/shapeio that referenced this issue Jan 24, 2023
viciious added a commit to viciious/shapeio that referenced this issue Jan 24, 2023
viciious added a commit to viciious/shapeio that referenced this issue Jan 24, 2023
viciious added a commit to viciious/shapeio that referenced this issue Jan 24, 2023
viciious added a commit to viciious/shapeio that referenced this issue Jan 24, 2023
viciious added a commit to viciious/shapeio that referenced this issue Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant