Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use set_exception instead of set_exception_info #6

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

romasku
Copy link

@romasku romasku commented May 4, 2020

set_exception_info method is only available in python2 backport
of concurrent.futures, while set_exception method available
everywhere.

This fixes issue #5.

set_exception_info method is only available in python2 backport
of concurrent.futures, while set_exception method available
everywhere.
Copy link
Contributor

@initialed85 initialed85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I sat on this for so long mate- LGTM, tests fine on both Py2 and Py3. In it goes!

@initialed85 initialed85 merged commit ae0915b into ftpsolutions:master Aug 18, 2020
@initialed85
Copy link
Contributor

Will do a release shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants