implement SMBPath and tests #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for the PR! ❤️ I'll be able to review it in about a week or two when I'm back from holiday. |
|
If I can help to fix the failing tests please let me know, I definitely need some pointers. Locally everything worked :-) |
|
@ap-- any chance to move this forward? |
|
Hi @tharwan It's on my immediate todo list. It's been a bit busy at work since I am back from holiday. Cheers, |
|
@tharwan thanks again for the PR ❤️ I made some minor adjustments and made the tests pass. Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement SMBPath and tests addressing #217
Close #217