Remove Query::variables()

fsaintjacques · Jan 24, 2020 · d76cac9 · d76cac9
1 parent 63c3c1f
commit d76cac9
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 7 deletions.
diff --git a/include/jitmap/query/query.h b/include/jitmap/query/query.h
@@ -47,9 +47,6 @@ class Query : util::Pimpl<QueryImpl> {
  // Return the expression of the query.
  const Expr& expr() const;
 
- // Return the names of the referenced bitmap (variables) in the expression.
- const std::vector<std::string>& variables() const;
-
  private:
  Query(std::string name, std::string query, ExecutionContext* context);
 };

diff --git a/src/jitmap/query/query.cc b/src/jitmap/query/query.cc
@@ -32,15 +32,13 @@ class QueryImpl {
  query_(std::move(query)),
  expr_(Parse(query_, &builder_)),
  optimized_expr_(Optimizer(&builder_).Optimize(*expr_)),
- variables_(expr_->Variables()),
  context_(context) {}
 
  // Accessors
  const std::string& name() const { return name_; }
  const std::string& query() const { return query_; }
  const Expr& expr() const { return *expr_; }
  const Expr& optimized_expr() const { return *optimized_expr_; }
- const std::vector<std::string>& variables() const { return variables_; }
  DenseEvalFn impl() const { return context_->jit()->LookupUserQuery(name()); }
 
  private:
@@ -49,7 +47,6 @@ class QueryImpl {
  ExprBuilder builder_;
  Expr* expr_;
  Expr* optimized_expr_;
- std::vector<std::string> variables_;
  ExecutionContext* context_;
 };
 
@@ -68,7 +65,6 @@ std::shared_ptr<Query> Query::Make(const std::string& name, const std::string& e
 
 const std::string& Query::name() const { return impl().name(); }
 const Expr& Query::expr() const { return impl().expr(); }
-const std::vector<std::string>& Query::variables() const { return impl().variables(); }
 
 } // namespace query
 } // namespace jitmap